Closed Bug 1682128 Opened 5 years ago Closed 5 years ago

The checkboxes on the new print UI do not match the checkboxes on e.g. about:preferences

Categories

(Toolkit :: Printing, defect)

defect

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed
firefox86 --- verified

People

(Reporter: itiel_yn8, Assigned: emmamalysz)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v85])

Attachments

(2 files, 1 external file)

Attached image Screenshot —

See attached.
Bug 1678333 made the checkboxes and radiobuttons look differently to match Photon.
That, with the custom checkboxes styling of the print UI, made the V in the checkbox to be styled incorrectly.
Removing this rule seems to fix it:
https://searchfox.org/mozilla-central/rev/4415bec7a49c50a338167d9c8934527b9cae59d0/toolkit/components/printing/content/print.css#126-128

Also, the radio buttons are now styled differently from e.g. about:preferences radiobuttons (I think that's because the radiobuttons are <input> and not <radio>).
I think the question should be if the print UI design choice should remain the same, or be aligned with e.g. about:preferences to match Photon (I know Proton is upon us, but still).

Set release status flags based on info from the regressing bug 1678333

Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89d37788f437 fix checkbox color in print settings r=mstriemer
Whiteboard: [print2020_v85]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

Comment on attachment 9193575 [details]
Bug 1682128, fix checkbox color in print settings

Beta/Release Uplift Approval Request

  • User impact if declined: It is difficult to see if a checkbox is selected in the new print preview
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Open the new print preview
  1. Check that the checkboxes are now blue with a white checkmark
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No string changes
  • String changes made/needed: n/a
Attachment #9193575 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Hello,

Confirming this issue as verified fixed. Checked with Win10x64, macOS 10.15.7 and Ubuntu 20.04 on Fx Nightly 86.0a1(20201217214927). NI myself to verify this in beta as well.

Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(vlad.lucaci)

Comment on attachment 9193575 [details]
Bug 1682128, fix checkbox color in print settings

Approved for 85.0b4.

Attachment #9193575 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+

Hello,

Confirming this issue as verified fixed on 86.0a1(20201220093524) and 85.0b4(20201220193140). Checked using Win10x64,macOS 10.15.7, Ubuntu 20.04.

Flags: needinfo?(vlad.lucaci)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: