1682128 - The checkboxes on the new print UI do not match the checkboxes on e.g. about:preferences

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Itiel]

Attachment: Screenshot

See attached.
Bug 1678333 made the checkboxes and radiobuttons look differently to match Photon.
That, with the custom checkboxes styling of the print UI, made the V in the checkbox to be styled incorrectly.
Removing this rule seems to fix it:
https://searchfox.org/mozilla-central/rev/4415bec7a49c50a338167d9c8934527b9cae59d0/toolkit/components/printing/content/print.css#126-128

Also, the radio buttons are now styled differently from e.g. about:preferences radiobuttons (I think that's because the radiobuttons are <input> and not <radio>).
I think the question should be if the print UI design choice should remain the same, or be aligned with e.g. about:preferences to match Photon (I know Proton is upon us, but still).

Comment 1

[Itiel]

Attachment: How radiobuttons are now styled

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1678333

Comment 3

[Emma Malysz]

Attachment: Bug 1682128, fix checkbox color in print settings

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89d37788f437
fix checkbox color in print settings r=mstriemer

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/89d37788f437

Comment 6

[Emma Malysz]

Comment on attachment 9193575 [details]
Bug 1682128, fix checkbox color in print settings

Beta/Release Uplift Approval Request

• User impact if declined: It is difficult to see if a checkbox is selected in the new print preview
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the new print preview

2. Check that the checkboxes are now blue with a white checkmark

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No string changes
• String changes made/needed: n/a

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed. Checked with Win10x64, macOS 10.15.7 and Ubuntu 20.04 on Fx Nightly 86.0a1(20201217214927). NI myself to verify this in beta as well.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193575 [details]
Bug 1682128, fix checkbox color in print settings

Approved for 85.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/db1ef141194b

Comment 10

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 86.0a1(20201220093524) and 85.0b4(20201220193140). Checked using Win10x64,macOS 10.15.7, Ubuntu 20.04.