Closed Bug 1682238 Opened 3 years ago Closed 3 years ago

Override navigator.userAgent for gamearter.com on macOS 11.0

Categories

(Web Compatibility :: Interventions, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox83 unaffected, firefox84 verified, firefox85 verified, firefox86 verified)

VERIFIED FIXED
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- verified
firefox85 --- verified
firefox86 --- verified

People

(Reporter: denschub, Assigned: denschub)

References

Details

Attachments

(2 files)

See bug 1680516 for context and details.

Beta-uplift for inclusion in 84 was explicitly requested in https://bugzilla.mozilla.org/show_bug.cgi?id=1680516#c15 from :RyanVM.

Pushed by dschubert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fc684b41c8d
Override navigator.userAgent for gamearter.com on macOS 11.0. r=ksenia,webcompat-reviewers
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Does this also cover 11.1?

Flags: needinfo?(dschubert)

It actually does not. I'll make adjustments to that patch momentarily.

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Beta/Release Uplift Approval Request

  • User impact if declined: As explained in bug 1680516, one or more games on gamearter.com would not load for ARM-based Mac users.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Change is limited to gamearter.com using a known-good mechanism, and the User Agent override only applies to ARM-based Mac users anyway.
  • String changes made/needed:
Attachment #9193047 - Flags: approval-mozilla-release?
Attachment #9193047 - Flags: approval-mozilla-beta?
Attachment #9193309 - Flags: approval-mozilla-release?
Attachment #9193309 - Flags: approval-mozilla-beta?

Sorry for the flag-spam! After chatting to Ryan on Slack, it seems possible (and maybe easier) to graft both patches to beta and release. However, if you run into any issues with that, please do let me know and I'll build a patch based on the release branch. :)

Note that when merging this to release, please make sure that version in browser/extensions/webcompat/manifest.json is changed to 17.1.0, not to 18.2.0. It's not a huge deal if that doesn't happen, but that'll make our Balrog rollout a bit easier. :)

Also ni?'ing myself for the Balrog rollout.

Flags: needinfo?(dschubert)
Pushed by dschubert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b5cccae9d1e
Follow-up: Replace all macOS 11.x User Agent strings, not just 11.0. r=ksenia,webcompat-reviewers
See Also: → 1682792

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

approved for 85.0b3

Attachment #9193047 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9193309 [details]
Bug 1682238 - Follow-up: Replace all macOS 11.x User Agent strings, not just 11.0. r=ksenia!

approved for 85.0b3

Attachment #9193309 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Do we need to uplift this patch to ESR 78? Can Intel builds of ESR 78 run on Apple Silicon using Rosetta?

I assume we don't need to uplift to Firefox 83 now that 84 is out.

AIUI 78 doesn't need this, the issue affects native arm builds which are new in 84.

Flags: needinfo?(dschubert)

Reproduced the issue described in bug 1680516 using the release version 84.
Verified - Fixed in latest Nightly 86.0a1 (build id: 20201220093524) and Beta 85.0b4 (build id: 20201220193140), both of them started with and without Rosetta, using miniMac: MacOS Big Sur 11.0.1, Mac mini (M1, 2020), Chip: Apple M1.

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Approved for 84.0.1

Attachment #9193047 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9193309 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified - Fixed in 84.0.1 with and without Rosetta, using miniMac: MacOS Big Sur 11.0.1, Mac mini (M1, 2020), Chip: Apple M1. The game is loaded accordingly and can be played without issues.

Status: RESOLVED → VERIFIED
See Also: → 1690779
See Also: → 1690737
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: