1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0

Status: VERIFIED FIXED

(Web Compatibility :: Interventions, defect)

Description

[Dennis Schubert [:denschub]]

See bug 1680516 for context and details.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Comment 2

[Dennis Schubert [:denschub]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Beta/Release Uplift Approval Request

• User impact if declined: As explained in bug 1680516, one or more games on gamearter.com would not load for ARM-based Mac users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change is limited to gamearter.com using a known-good mechanism, and the User Agent override only applies to ARM-based Mac users anyway.
• String changes made/needed:

Comment 3

[Dennis Schubert [:denschub]]

Beta-uplift for inclusion in 84 was explicitly requested in https://bugzilla.mozilla.org/show_bug.cgi?id=1680516#c15 from :RyanVM.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc684b41c8d
Override navigator.userAgent for gamearter.com on macOS 11.0. r=ksenia,webcompat-reviewers

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

84 is on mozilla-release now.
[edit: fix version...]

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4fc684b41c8d

Comment 7

[Julien Cristau [:jcristau]]

Does this also cover 11.1?

Comment 8

[Dennis Schubert [:denschub]]

It actually does not. I'll make adjustments to that patch momentarily.

Comment 9

[Dennis Schubert [:denschub]]

Attachment: Bug 1682238 - Follow-up: Replace all macOS 11.x User Agent strings, not just 11.0. r=ksenia!

Comment 10

[Dennis Schubert [:denschub]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Canceling uplift requests - I'll build you a patch specifically for the release branch.

Comment 11

[Dennis Schubert [:denschub]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Beta/Release Uplift Approval Request

• User impact if declined: As explained in bug 1680516, one or more games on gamearter.com would not load for ARM-based Mac users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change is limited to gamearter.com using a known-good mechanism, and the User Agent override only applies to ARM-based Mac users anyway.
• String changes made/needed:

Comment 12

[Dennis Schubert [:denschub]]

Sorry for the flag-spam! After chatting to Ryan on Slack, it seems possible (and maybe easier) to graft both patches to beta and release. However, if you run into any issues with that, please do let me know and I'll build a patch based on the release branch. :)

Note that when merging this to release, please make sure that version in browser/extensions/webcompat/manifest.json is changed to 17.1.0, not to 18.2.0. It's not a huge deal if that doesn't happen, but that'll make our Balrog rollout a bit easier. :)

Also ni?'ing myself for the Balrog rollout.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b5cccae9d1e
Follow-up: Replace all macOS 11.x User Agent strings, not just 11.0. r=ksenia,webcompat-reviewers

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1b5cccae9d1e

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

approved for 85.0b3

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 9193309 [details]
Bug 1682238 - Follow-up: Replace all macOS 11.x User Agent strings, not just 11.0. r=ksenia!

approved for 85.0b3

Comment 17

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/28e5e906f407
https://hg.mozilla.org/releases/mozilla-beta/rev/a4c197b82850

Comment 18

[Chris Peterson [:cpeterson]]

Do we need to uplift this patch to ESR 78? Can Intel builds of ESR 78 run on Apple Silicon using Rosetta?

I assume we don't need to uplift to Firefox 83 now that 84 is out.

Comment 19

[Julien Cristau [:jcristau]]

AIUI 78 doesn't need this, the issue affects native arm builds which are new in 84.

Comment 20

[Alin Ilea, Desktop Test Engineering]

Reproduced the issue described in bug 1680516 using the release version 84.
Verified - Fixed in latest Nightly 86.0a1 (build id: 20201220093524) and Beta 85.0b4 (build id: 20201220193140), both of them started with and without Rosetta, using miniMac: MacOS Big Sur 11.0.1, Mac mini (M1, 2020), Chip: Apple M1.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193047 [details]
Bug 1682238 - Override navigator.userAgent for gamearter.com on macOS 11.0. r?ksenia!

Approved for 84.0.1

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/a7908751ce86
https://hg.mozilla.org/releases/mozilla-release/rev/88e4de109bfa

Comment 23

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in 84.0.1 with and without Rosetta, using miniMac: MacOS Big Sur 11.0.1, Mac mini (M1, 2020), Chip: Apple M1. The game is loaded accordingly and can be played without issues.