Closed
Bug 1682242
Opened 3 years ago
Closed 3 years ago
UnknownException: TypeError: can't access property "tabs", tabBrowser is null
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(Fission Milestone:M7, firefox-esr78 unaffected, firefox84 unaffected, firefox85 fixed, firefox86 fixed)
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox84 | --- | unaffected |
firefox85 | --- | fixed |
firefox86 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [marionette-fission-mvp])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
With the patch on bug 1676671 landed, the initial browser collection is broken if there is a non-browser window open. The failure looks like:
1607940033466 Marionette DEBUG 3 <- [1,1,{"error":"unknown error","message":"TypeError: can't access property \"tabs\", tabBrowser is null","stacktrace":"GeckoDr ... t@chrome://marionette/content/server.js:241:9\n_onJSONObjectReady/<@chrome://marionette/content/transport.js:504:20\n"},null]
Marionette threw an error: TypeError: can't access property "tabs", tabBrowser is null
GeckoDriver.prototype.newSession@chrome://marionette/content/driver.js:876:25
despatch@chrome://marionette/content/server.js:297:40
execute@chrome://marionette/content/server.js:267:16
onPacket/<@chrome://marionette/content/server.js:240:20
onPacket@chrome://marionette/content/server.js:241:9
_onJSONObjectReady/<@chrome://marionette/content/transport.js:504:20
Assignee | ||
Comment 1•3 years ago
|
||
I set this bug as high priority because this failure blocks Marionette unit tests for Thunderbird.
Assignee | ||
Updated•3 years ago
|
status-firefox84:
--- → unaffected
status-firefox85:
--- → affected
status-firefox86:
--- → affected
Assignee | ||
Comment 2•3 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf468d20cd8e [marionette] Correctly register chrome windows without a tab browser in "WebDriver:NewSession". r=marionette-reviewers,jgraham
Updated•3 years ago
|
Fission Milestone: --- → MVP
Updated•3 years ago
|
Fission Milestone: MVP → M7
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Assignee | ||
Updated•3 years ago
|
Whiteboard: [marionette-fission-reserve] → [marionette-fission-mvp]
Assignee | ||
Comment 5•3 years ago
|
||
Comment on attachment 9193030 [details]
Bug 1682242 - [marionette] Correctly register chrome windows without a tab browser in "WebDriver:NewSession".
Beta/Release Uplift Approval Request
- User impact if declined: Using WebDriver (Marionette) the new session command will fail if windows are open that are no browser windows. This actually affects Thunderbird as well.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): A
null
check has been added to prevent the Javascript error. - String changes made/needed: none
Attachment #9193030 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•3 years ago
|
Severity: S3 → S2
Comment 6•3 years ago
|
||
Comment on attachment 9193030 [details]
Bug 1682242 - [marionette] Correctly register chrome windows without a tab browser in "WebDriver:NewSession".
approved for 85.0b2
Attachment #9193030 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•3 years ago
|
status-firefox-esr78:
--- → unaffected
Comment 7•3 years ago
|
||
bugherder uplift |
Flags: in-testsuite+
Comment hidden (Intermittent Failures Robot) |
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•