1682365 - Improve render task graph v2

Remove usage of the implicit prev pass alpha and color texture
samplers from batching / renderer / shader code. They are replaced
by explicit references to the texture ID for the source task.

Glenn Watson [:gw]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1682365 - Pt 2 - Remove texture array usage from render task graph. — Details

With this change, all color/alpha intermediate surfaces are individual
textures, rather than texture arrays.

This can in theory cause more batch breaks in some cases, but this
is likely to be very rare in practice.

Benefits:

No more allocating the array at the size of the largest task / slice.
Remove a source of many driver bugs on android devices.
Simplify integration of future patches with render task graph.

Much of the render target array texture code is still present, since
picture cache tiles in the Draw compositor still make use of texture
arrays. However, once these are switched to normal textures, we can
remove most of the slice layer, blit workaround functionality etc.

Remove the default feature setting for selecting the image sampler
kind. Instead, this must be explicitly specified by the shader or
a dynamic feature define, which makes sampler selection less error prone.

Glenn Watson [:gw]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1682365 - Pt 3 - Remove array textures from picture cache tiles. — Details

This patch makes picture cache tiles use normal textures instead
of array textures. With this and the previous patch, WR no longer
uses array textures at all (except when provided by the external
image handler trait).

Glenn Watson [:gw]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1682365 - Pt 4 - Add RenderTaskGraphBuilder / RenderTaskGraph split — Details

This patch splits the graph building functionality into
RenderTaskGraphBuilder and the graph querying code into
the existing RenderTaskGraph struct.

The Builder struct is retained frame to frame, which means
there is no longer a need for the RenderTaskGraphCounters
struct. The Graph struct is constructed per-frame by calling
end_pass on the Builder.

Although this doesn't do much different internally, it will
make integration with the new task graph changes simpler. It
also enforced during frame building when it is possible
to add / query render tasks.

A few unrelated tidy ups are included in this patch - mostly
removing where the task graph is passed to from a few structs
and methods that no longer require access to the graph.

Glenn Watson [:gw]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1682365 - Pt 5 - Refactor RenderTaskLocation — Details

Once the new graph API is in place, it becomes possible to express
an input dependency on a persistent target (for example, if wanting
to read back from a picture cache tile for a mix-blend, or marking
that a color target depends on a render task in a texture cache).

To make that simpler to express, this patch adds a specific struct
for render target locations that are persistent, and updates the
surrounding code to use it. At the same time, introduce an Unallocated
field for dynamic tasks that are not yet allocated, rather than
using an Option.

Pulsebot

Comment 7

•

5 years ago

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c03e3ad5e56 Pt 1 - Remove PrevPassAlpha and PrevPassColor r=nical

Pulsebot

Comment 8

•

5 years ago

Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15da94c6a7b1 Pt 2 - Remove texture array usage from render task graph. r=nical

Cristian Brindusan [:cbrindusan]

Comment 9

•

5 years ago

Backed out changeset 15da94c6a7b1 (Bug 1682365) for wrench bustage at shadow-transforms.yaml and multi-mix-blend-mode.yaml.
https://hg.mozilla.org/integration/autoland/rev/f769fe6be284226422f661e3d22ed77f81760d1d

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=15da94c6a7b19f971d3dffaa4cab8edb8e41cb62&selectedTaskRun=V-gs_lN-QW-Vd_kF6tioTw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=324511483&repo=autoland&lineNumber=1466
https://treeherder.mozilla.org/logviewer?job_id=324511067&repo=autoland&lineNumber=2537

Flags: needinfo?(gwatson)

Glenn Watson [:gw]

Assignee

Bug 1682365 - Pt 1 - Remove PrevPassAlpha and PrevPassColor 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1682365 - Pt 2 - Remove texture array usage from render task graph. 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1682365 - Pt 3 - Remove array textures from picture cache tiles. 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1682365 - Pt 4 - Add RenderTaskGraphBuilder / RenderTaskGraph split 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1682365 - Pt 5 - Refactor RenderTaskLocation 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1682365 - Pt 6 - Add new frame graph implementation. 5 years ago Glenn Watson [:gw] 47 bytes, text/x-phabricator-request		Details \| Review

Ratio	Suite	Platform	Options	Absolute values (old vs new)
9%	Heap Unclassified	linux1804-64-shippable-qr	tp6	281,405,490.24 -> 255,320,478.19
5%	Explicit Memory	linux1804-64-shippable-qr	tp6	699,490,659.96 -> 662,534,543.90
4%	Resident Memory	linux1804-64-shippable-qr	tp6	1,044,652,184.52 -> 999,031,733.73
4%	Resident Memory	linux1804-64-shippable-qr	tp6	1,037,727,956.92 -> 1,000,061,288.32

Improve render task graph v2

Improvements: