1682466 - Implement the SIMD "extended multiplication" instruction

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

See https://github.com/WebAssembly/simd/pull/376. This has been accepted into the spec, and V8, LLVM, emscripten, binaryen all support it now. Checklist:

[ x ] Test cases
[ x ] Wast
[ x ] Baseline (x86, x64, arm64)
[ x ] Ion (x86, x64)

Ion arm64 will land separately, with all the other Ion arm64 SIMD support (bug 1687629).

Opcodes as implemented in V8 and the tools: https://chromium-review.googlesource.com/c/v8/v8/+/2469156/4/src/wasm/wasm-opcodes.h

Comment 1

[Lars T Hansen [:lth]]

I'll take care of the non-cranelift bits.

Comment 2

[Lars T Hansen [:lth]]

Wast changes pending: https://github.com/bytecodealliance/wasm-tools/pull/174

Comment 3

[Lars T Hansen [:lth]]

Attachment: Bug 1682466 - SIMD extending multiply, baseline + ion + tests. r?jseward

Comment 4

[Lars T Hansen [:lth]]

I would like to have i64x.widen_i32x4_{s,u} for the test cases for the extending multiplication, so take a dependency.

Comment 5

[Lars T Hansen [:lth]]

Attachment: Bug 1682466 - Update wat to 1.0.31. r?rhunt

This version contains new opcodes for ExtMul.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7187860cb553
Update wat to 1.0.31. r=rhunt

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7187860cb553

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c25ac5c7acc0
SIMD extending multiply, baseline + ion + tests.  r=jseward

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c25ac5c7acc0