Closed Bug 1682500 Opened 4 years ago Closed 4 years ago

Split the SIMD ad-hack tests

Categories

(Core :: JavaScript: WebAssembly, task, P3)

task

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The ad-hack test cases are taking a long time to run and have a propensity to time out, especially after I added the exhaustive testing of binops and unops to try with all combinations of variable and constant arguments. We should split into two files.

First, split off common code into ad-hack-preamble.js and include this
file from everywhere.

Second, the regular binops take by far the longest, and the regular
unops the second longest, in both cases because they check so many
variants. So factor them into their own files.

Further split the binary operations into three different files to
unlock more parallelism. This means the binops all go in
ad-hack-binop-preamble.js and the test cases in
ad-hack-simple-binops*.js just pick the subset to run, while unops go
in ad-hack-simple-unops.js.

Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff8571ed79bc Split test cases to avoid timeouts. r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: