Closed Bug 1682571 Opened 5 months ago Closed 5 months ago

Update libpref prefs_file_was_invalid telemetry

Categories

(Core :: Preferences: Backend, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

Details

Attachments

(2 files, 1 obsolete file)

We already have telemetry on invalid prefs files but it expired in firefox 62. We would like to know if a certain data race (bug 1681950) is causing prefs file corruption.

We are interested in knowing if and when the prefs file fails to read. Since Preferences silently handles this failute by resetting the prefs file (which is not ideal), the best way to find out if this is failing is via telemetry probe. The prefs_file_was_invalid telemetry already exists so it only needs to be updated.

Attached file Preferences data collection renewal (obsolete) —
Attachment #9193534 - Flags: data-review?(chutten)
Assignee: nobody → kwright
Status: NEW → ASSIGNED

Comment on attachment 9193534 [details]
Preferences data collection renewal

The short renewal form sadly can't be used in this case because:

  • It can only be used for renewing an expiring collection. Extending it to be permanent isn't covered because the requestor now need to identify an owner for the data and the steward needs an opportunity to recommend you write regression tests around the instrumentation.
  • The original data collection review didn't use a form, predating the use of review requests. So we'll need to fill out one.

Please resubmit using the longer form.

Attachment #9193534 - Flags: data-review?(chutten) → data-review-

I've never gone over this process before, so please let me know if there's anything I need to update or change!

Attachment #9193534 - Attachment is obsolete: true
Attachment #9194013 - Flags: data-review?(chutten)

Comment on attachment 9194013 [details]
data-collection-review-form.md

You did quite well!

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kris Wright is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.


Result: datareview+

Attachment #9194013 - Flags: data-review?(chutten) → data-review+
Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e08861664dc5
Update prefs_file_was_invalid telemetry r=chutten,decoder
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.