1682634 - Add test coverage for screenshot dimensions

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

We need some tests that cover the full page, partial page and cropping UI. The only tests enabled currently are smoke tests that verify the screenshots button is in the page actions menu.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1682634 - Add a mochitest-chrome test for the screenshot flow and result dimensions. r?emalysz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64e8532c9a0b
Add a mochitest-chrome test for the screenshot flow and result dimensions. r=emalysz

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 64e8532c9a0b (bug 1682634) for causing bc failures in browser_screenshots_dimensions.js.
https://hg.mozilla.org/integration/autoland/rev/a81b46bef82fcd2f0e63cae11464283abe9a2fce

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=64e8532c9a0bb62a68cd7d078a4f387c22d337bc&selectedTaskRun=DAU0B5A5RnelY07QGFJybQ.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=341590599&repo=autoland&lineNumber=2423

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to Cristian Brindusan [:cbrindusan] from comment #4)

Backed out changeset 64e8532c9a0b (bug 1682634) for causing bc failures in browser_screenshots_dimensions.js.

Thanks for the backout. I "fixed" 2 issues there - thetodo_is assertions apparently do resolve true on some platforms/configs.
And the tsan timeouts. This try push looks good now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5095216d84d5
Add a mochitest-chrome test for the screenshot flow and result dimensions. r=emalysz

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5095216d84d5