1682709 - ./mach reftest fails on Mac

Status: RESOLVED WORKSFORME

(Testing :: Reftest, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Error running mach:

    ['reftest']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file reftest| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

shutil.Error: [('/Users/jrmuizel/source/gecko-inbound/obj-opt/dist/plugins/ThirdTest.plugin/Contents/Info.plist', '/var/folders/z2/52nrrnjx24z2fd60wd6glw1w0000gn/T/tmphj2znqno.mozrunner/plugins/ThirdTest.plugin/Contents/Info.plist', "[Errno 2] No such file or directory: '/Users/jrmuizel/source/gecko-inbound/obj-opt/dist/plugins/ThirdTest.plugin/Contents/Info.plist'")]

  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/mach_commands.py", line 242, in run_reftest
    return self._run_reftest(**kwargs)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/mach_commands.py", line 305, in _run_reftest
    return reftest.run_desktop_test(**kwargs)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/mach_commands.py", line 106, in run_desktop_test
    rv = runreftest.run_test_harness(parser, args)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 1150, in run_test_harness
    result = reftest.runTests(options.tests, options)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 697, in runTests
    return self.runSerialTests(manifests, options, cmdargs)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 1080, in runSerialTests
    tests = self.getActiveTests(manifests, options)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 1007, in getActiveTests
    self.runApp(options, cmdargs=cmdargs, prefs=prefs)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 865, in runApp
    profile = self.createReftestProfile(options, **profileArgs)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 516, in createReftestProfile
    self.copyExtraFilesToProfile(options, profile)
  File "/Users/jrmuizel/source/gecko-inbound/layout/tools/reftest/runreftest.py", line 1119, in copyExtraFilesToProfile
    shutil.copytree(abspath, dest)
  File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/shutil.py", line 554, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "/usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/shutil.py", line 510, in _copytree
    raise Error(errors)
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

Comment 1

[Jon Bauman [:jbauman:]]

Attachment: mochitest failure full log

Seeing the same error with `mochitest`:
```

Comment 2

[Jon Bauman [:jbauman:]]

Attachment: mochitest failure log

Seeing the same error with mochitest

Comment 3

[Jon Bauman [:jbauman:]]

Debugging a bit:

"[Errno 2] No such file or directory: u'/Users/jbauman/src/mozilla-unified/obj-ff-dbg/dist/plugins/ThirdTest.plugin/Contents/Info.plist'"

This error seems to come from the fact that mozilla-unified/obj-ff-dbg/dist/plugins/ThirdTest.plugin/Contents/Info.plist is a symlink to -> mozilla-unified/dom/plugins/test/testplugin/thirdplugin/Info.plist, which was removed in https://hg.mozilla.org/mozilla-central/rev/bb1aa4e811e7. Maybe there should've been a clobber build triggered that wasn't for some reason?

Removing mozilla-unified/obj-ff-dbg/dist/plugins/ThirdTest.plugin seems to have fixed the issue for me.

Comment 4

[Jon Bauman [:jbauman:]]

David Parks, any idea what happened here?

Comment 5

[David Parks [:handyman]]

Comment 3's suggestion that bug 1675349 needed a clobber build sounds believable. The mac symlink must need to be manually cleared out by clobber. I don't know the rules for updating the CLOBBER file but I assume its a bit late for that anyway. Unless there are objections, I'd close this as WORKSFORME.