1682759 - New wpt failures in /css/css-images/image-orientation/image-orientation-exif-png.html (Firefox doesn't support EXIF orientation data from PNG images)

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 26915 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

/css/css-images/image-orientation/image-orientation-exif-png.html: FAIL (Chrome: FAIL, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1682720 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Intermittent Failures Robot]

1 failures in 4622 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1682759&startday=2021-03-08&endday=2021-03-14&tree=all

Comment 2

[Daniel Holbert [:dholbert]]

This probably more-directly belongs in ImageLib, given that per https://github.com/w3c/PNG-spec/issues/310#issuecomment-1883520532 it seems the issue is just the fact that we ignore (don't parse?) EXIF information from PNG images.

If we had that information parsed/available in imagelib, presumably we would honor it in layout, just like we do for JPEG images.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1682759. Support format conversion for re-orienting surface pipes. r?#gfx-reviewers

Refactor the format conversion code to a function so we can re-use it.

To update the giant if in CreateReorientSurfacePipe I just copied the one from CreateSurfacePipe and then removed cases that were not possible so it should be correct.

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1682759. Support parsing exif data that skips the leading exif id code header. r?#gfx-reviewers

Exif data in jpegs includes the leading "Exif\0\0", but exif data in pngs does not include it.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1682759. mFrameRect in png decoder is in unoriented space. r?#gfx-reviewers

The conversion from unoriented to oriented (ie exif rotations/flips) happens at the last step in the surface pipe. mFrameRect is mostly used for things that are before this last step. There are a few uses where mFrameRect needs to be in oriented space so we just convert at those places.

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1682759. Support exif data in pngs. r?#gfx-reviewers

Since the reorienting surface pipe doesn't support some features we need to prioritize. If the png has animation then we ignore exif data. We disable progressive display and interlacing if the png has exif data and the effect is not the identity (we don't take advantage of the improved experience while the image is loading, but it still works fine when fully loaded).

Comment 7

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1682759. Update text expectations. r?#gfx-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9f84aa2de9e4
https://hg.mozilla.org/integration/autoland/rev/dcf7149b158a
Support format conversion for re-orienting surface pipes. r=gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/ec25434d547d
https://hg.mozilla.org/integration/autoland/rev/47343fe09bee
Support parsing exif data that skips the leading exif id code header. r=gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/ab05f857461b
https://hg.mozilla.org/integration/autoland/rev/e868911a9ef8
mFrameRect in png decoder is in unoriented space. r=gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/e917070bc454
https://hg.mozilla.org/integration/autoland/rev/99942e19563a
Support exif data in pngs. r=gfx-reviewers,nical
https://github.com/mozilla-firefox/firefox/commit/4304f80dd076
https://hg.mozilla.org/integration/autoland/rev/269977aed38a
Update text expectations. r=gfx-reviewers,nical

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dcf7149b158a
https://hg.mozilla.org/mozilla-central/rev/47343fe09bee
https://hg.mozilla.org/mozilla-central/rev/e868911a9ef8
https://hg.mozilla.org/mozilla-central/rev/99942e19563a
https://hg.mozilla.org/mozilla-central/rev/269977aed38a