1682764 - SQL syntax error when expiring `try` data

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

Seems like there's a bug with expiring try data. The error is as follows:

    WARNING [treeherder.model.management.commands.cycle_data:117] No data cycling could be performed. (Reason: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')\n LIMIT 100' at line 2"))

Looking closer into what caused this, it seems this is the problematic SQL query:

    DELETE FROM `performance_datum`
    WHERE repository_id = %s AND push_timestamp <= %s AND ()
    LIMIT %s

with the AND () being the invalid portion.

Note: this is only happening when there aren't any signatures associated with the try repository. In normal circumstances, this should never happen.

This bug only reproduces on the treeherder-prototype2 environment, because it's not ingesting any try data (in order to keep its disk usage to a minimum).
Jira link: https://jira.mozilla.com/browse/FXP-1391

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6919