1682887 - Roll out 2h2020 bookmarks changes with 85 release

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[:Gijs (he/him)]

We're sufficiently confident that we want to roll this out with 85, so we should set the pref in-tree on beta and nightly to be always-on.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1682887 - roll out 2h2020 bookmarks pref to 100% on 85 and later, r?jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fb2221a1057
roll out 2h2020 bookmarks pref to 100% on 85 and later, r=jaws

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6fb2221a1057

Comment 4

[:Gijs (he/him)]

Comment on attachment 9193524 [details]
Bug 1682887 - roll out 2h2020 bookmarks pref to 100% on 85 and later, r?jaws

Beta/Release Uplift Approval Request

• User impact if declined: Have to wait for normandy to enable this on 85
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: (no explicit verification needed as it's a pref flip)
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a pref flip
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9193524 [details]
Bug 1682887 - roll out 2h2020 bookmarks pref to 100% on 85 and later, r?jaws

approved for 85.0b3

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02ea99ac9e96

Comment 7

[Pascal Chevrel:pascalc]

Gijs, is a release note needed ? (for both Beta and Release) thanks

Comment 8

[:Gijs (he/him)]

(In reply to Pascal Chevrel:pascalc from comment #7)

Gijs, is a release note needed ? (for both Beta and Release) thanks

Probably. Romain, can you review this:

Release Note Request (optional, but appreciated)
[Why is this notable]: Number of bookmarks-related changes
[Affects Firefox for Android]: No
[Suggested wording]: Firefox now remembers where you save bookmarks, will show the bookmarks toolbar on its new tab page, and has a convenient button to import bookmarks from other profiles and to show bookmarks stored in the "Other bookmarks" folder.
[Links (documentation, blog post, etc)]: Unsure if we have something reasonably user-facing for this. Romain?

Comment 9

[Romain Testard [:RT]]

Thanks, this looks good to me, only thing that reads odd is " Firefox now remembers where you save bookmarks" - how about instead using "It's now simpler to retrieve your bookmarks on Firefox" ?

Release Note Request (optional, but appreciated)
[Why is this notable]: Number of bookmarks-related changes
[Affects Firefox for Android]: No
[Suggested wording]:It's now simpler to retrieve your bookmarks on Firefox. Users can now access the bookmarks toolbar on its new tab page, and usea convenient button to import bookmarks from other profiles and to show bookmarks stored in the "Other bookmarks" folder.
[Links (documentation, blog post, etc)]: https://support.mozilla.org/en-US/kb/bookmarks-firefox and https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_bookmarks will be updated in time for when 85 hits release with https://bugzilla.mozilla.org/show_bug.cgi?id=1685504

Comment 10

[Pascal Chevrel:pascalc]

Note added to our beta notes (without the links provided as the content is not done yet)

Comment 11

[Julien Cristau [:jcristau]]

This was in the 85.0 release notes.