Closed Bug 1683077 Opened 4 years ago Closed 4 years ago

Missing closing bracket in NewPasswordModel.jsm selector

Categories

(Toolkit :: Password Manager, defect, P2)

Product:
Toolkit
Component:
Password Manager
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1679452

People

(Reporter: ntim, Unassigned)

References

(Regression)

Details

(Keywords: regression)

https://searchfox.org/mozilla-central/rev/c7cf087b6e1384608ca3989f042f12f7cabd0a5f/toolkit/components/passwordmgr/NewPasswordModel.jsm#394

As Kartik Gautam pointed out to me via Matrix, the second :not is missing a closing bracket.

From initial testing, the selector works as it should, even without the missing bracket on document.querySelectorAll, but not sure in this very specific case.

Bianca, can you look into this or redirect to someone else?

Flags: needinfo?(bdanforth)

Bugbug thinks this bug is a defect, but please change it back in case of error.

Type: task → defect

I'll fix this.

Assignee: nobody → dlee
Severity: -- → S3
Status: NEW → ASSIGNED
Flags: needinfo?(bdanforth)
Priority: -- → P2

input[type=password]:not([disabled], [aria-hidden=true]) should be equivalent and shorter.

Bug 1679452 took care of this.

Assignee: dlee → nobody
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.