1683116 - Flicker and artifacts over entire window on https://www.vsynctester.com/ caused by remote canvas with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I just noticed this yesterday but regression windowed it to remote canvas being turned on. Flipping the pref confirmed it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Remote canvas is shipping now for the first time in 84 so this is somewhat worrying.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I see this on a Intel HD Graphics 530 but don't on a GTX 1080

Comment 3

[Bob Owen (:bobowen)]

Attachment: Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Comment 4

[Bob Owen (:bobowen)]

[Tracking Requested - why for this release]: there are concerns that this and particularly bug 1683120, might cause significant performance issues for people without webrender or advanced layers on Fx84

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b78c92616ff7
Disable remote canvas 2D for Release and late Beta. r=jrmuizel

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b78c92616ff7

Comment 7

[Bob Owen (:bobowen)]

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Beta/Release Uplift Approval Request

• User impact if declined: Performance issue for users without webrender or advanced layers.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a config change back to previous setting.
• String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Approved for 85.0b4.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe51ccd78ad9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9193774 [details]
Bug 1683116: Disable remote canvas 2D for Release and late Beta. r=jrmuizel!

Approved for 84.0.1.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/5eca81c4fd6a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Added to the Firefox 84.0.1 relnotes:

Fixed slower than expected performance and flickering on Canvas elements for some Windows users