Closed Bug 1683281 Opened 4 years ago Closed 3 years ago

Support observable array types

Categories

(Core :: DOM: Bindings (WebIDL), task, P2)

Product:
Core
Component:
DOM: Bindings (WebIDL)
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: annevk, Assigned: edgar)

References

Details

Attachments

(17 files, 9 obsolete files)

Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 5: Generate binding code for ObservableArray type; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Bug 1683281 - Part 7: Generate example code for ObservableArray; r=peterv
48 bytes, text/x-phabricator-request
Details | Review
Part5_generated_binding_code_D112280.cpp
53.27 KB, text/plain
Details
Part5_generated_binding_header_D112280.h
17.44 KB, text/plain
Details
Part6-1_binding_diff_D113728.patch
51.18 KB, patch
Details | Diff | Splinter Review
Part6-2_binding_header_diff_D113862.patch
2.59 KB, patch
Details | Diff | Splinter Review
Part6-2_binding_diff_D113862.patch
70.41 KB, patch
Details | Diff | Splinter Review
Part7_binding_diff_D115747.patch
1.20 MB, patch
Details | Diff | Splinter Review
Part3_diff.patch
2.78 KB, patch
Details | Diff | Splinter Review
Part5_diff.patch
9.88 KB, patch
Details | Diff | Splinter Review
Part5_generated_binding_code_diff_D112280.patch
7.89 KB, patch
Details | Diff | Splinter Review

To prioritize this bug it would be good to know if any features we plan to implement need this. (See also https://github.com/heycam/webidl/pull/840.)

Severity: -- → N/A
Type: defect → task
Priority: -- → P3
Blocks: 1520690
Flags: needinfo?(echen)
Assignee: nobody → echen
Flags: needinfo?(echen)
Priority: P3 → P2

Depends on D112280

Attachment #9216242 - Attachment description: WIP: Bug 1683281 - Part 5: Generate binding code for ObservableArray type; → WIP: Bug 1683281 - Part 5-1: Generate binding code for ObservableArray type;
Attachment #9216243 - Attachment description: WIP: Bug 1683281 - Part 6: Add test for ObservableArray type; → WIP: Bug 1683281 - Part 5-2: Add test for ObservableArray type;

Depends on D113728

Attachment #9219085 - Attachment description: WIP: Bug 1683281 - Part 6-1: C++ helper function; → WIP: Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class;
Attachment #9219086 - Attachment description: WIP: Bug 1683281 - Part 6-2: Add test for C++ helper function; → WIP: Bug 1683281 - Part 6-3: Add test for C++ helper function;
Attachment #9216237 - Attachment description: WIP: Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; → Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type;
Attachment #9216238 - Attachment description: WIP: Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; → Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h;
Attachment #9216239 - Attachment description: WIP: Bug 1683281 - Part 3: Add ObservableArrayProxyHandler; → Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class;
Attachment #9216240 - Attachment description: WIP: Bug 1683281 - Part 4: Add getObservableArrayBackingObject; → Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object;
Attachment #9216242 - Attachment description: WIP: Bug 1683281 - Part 5-1: Generate binding code for ObservableArray type; → Bug 1683281 - Part 5: Generate binding code for ObservableArray type;
Attachment #9216243 - Attachment is obsolete: true
Attachment #9219085 - Attachment description: WIP: Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; → Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class;
Attachment #9219351 - Attachment description: WIP: Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; → Bug 1683281 - Part 6-2: C++ helper function for ObservableArray;
Attachment #9219086 - Attachment is obsolete: true
Attachment #9223320 - Attachment is obsolete: true
Attachment #9223323 - Attachment is obsolete: true
Attachment #9216237 - Attachment description: Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; → Bug 1683281 - Part 1: Make WebIDL parser support ObservableArray type; r=peterv
Attachment #9216239 - Attachment description: Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class; → Bug 1683281 - Part 3: Add ObservableArrayProxyHandler base class; r=peterv
Attachment #9216240 - Attachment description: Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object; → Bug 1683281 - Part 4: Add helper method to get ObservableArray backing object; r=peterv
Attachment #9216238 - Attachment description: Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; → Bug 1683281 - Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv
Attachment #9216242 - Attachment description: Bug 1683281 - Part 5: Generate binding code for ObservableArray type; → Bug 1683281 - Part 5: Generate binding code for ObservableArray type; r=peterv
Attachment #9223319 - Attachment is obsolete: true
Attachment #9259491 - Attachment is obsolete: true
Attachment #9219085 - Attachment description: Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; → Bug 1683281 - Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; r=peterv
Attachment #9223324 - Attachment is obsolete: true
Attachment #9219351 - Attachment description: Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; → Bug 1683281 - Part 6-2: C++ helper function for ObservableArray; r=peterv
Attachment #9223326 - Attachment is obsolete: true
Attachment #9223328 - Attachment is obsolete: true
Attachment #9223066 - Attachment description: Bug 1683281 - Part 7: Generate example code for ObservableArray; → Bug 1683281 - Part 7: Generate example code for ObservableArray; r=peterv

(Note to myself: Need to address https://phabricator.services.mozilla.com/D112278#4435321 and add tests)

Attached patch Part3_diff.patch — — Splinter Review
Attachment #9266066 - Attachment description: part3_diff.patch → Part3_diff.patch
Attachment #9266066 - Attachment is patch: true
Attached patch Part5_diff.patch — — Splinter Review
Attachment #9266086 - Attachment is patch: true
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e3a03440cb0 Part 1: Make WebIDL parser support ObservableArray type; r=peterv https://hg.mozilla.org/integration/autoland/rev/3b574e19dc45 Part 2: Move proxy handler utility functions from DOMJSProxyHandler.h to ProxyHandlerUtils.h; r=peterv https://hg.mozilla.org/integration/autoland/rev/95071f254b91 Part 3: Add ObservableArrayProxyHandler base class; r=peterv https://hg.mozilla.org/integration/autoland/rev/5e3348c86dfd Part 4: Add helper method to get ObservableArray backing object; r=peterv https://hg.mozilla.org/integration/autoland/rev/bd45b431c375 Part 5: Generate binding code for ObservableArray type; r=peterv https://hg.mozilla.org/integration/autoland/rev/8af8c4503d68 Part 6-1: Create CGHelperFunctionGenerator and refactor into more generic base class; r=peterv https://hg.mozilla.org/integration/autoland/rev/d62f0deb8578 Part 6-2: C++ helper function for ObservableArray; r=peterv https://hg.mozilla.org/integration/autoland/rev/97d819698581 Part 7: Generate example code for ObservableArray; r=peterv
Regressions: 1759074
Regressions: 1759131
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: