Closed Bug 1683296 Opened 5 years ago Closed 3 years ago

Remove XUL equalsize="always" usages

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED DUPLICATE of bug 1798111

People

(Reporter: ntim, Unassigned)

References

(Blocks 1 open bug)

Details

https://searchfox.org/mozilla-central/search?q=equalsize&path=&case=false&regexp=false

There are only 6 usages in XHTML & JS files. This is actually useful, to force an equal width for the child elements. Prevents the child elements from controlling their own width, no matter what's inside (long wrapping text etc.).

The only usages in Firefox are mainly for table style layouts with a table header, to force columns to have the same width. I'm sure this is possible to do with CSS without special platform code.

When enabling layout.css.emulate-moz-box-with-flex, these attributes no longer take effect, and you can see the consequences when checking the usages.

Depends on: 1683303

I think there may be some overlap between the Thunderbird preferences file-type/action table, and the same table in Firefox, which currently uses equalsize:

https://searchfox.org/mozilla-central/rev/cca1566127a2fcc013e9c09f9d90ed70df2250a4/browser/components/preferences/main.inc.xhtml#383

You can look at how we handled this in Thunderbird, where we also improved the accessibility of the table, and fixed an alignment issue.

https://hg.mozilla.org/comm-central/rev/a0b86bbaaa09
https://phabricator.services.mozilla.com/D111399

Flags: needinfo?(gijskruitbosch+bugs)
Status: NEW → RESOLVED
Closed: 3 years ago
Duplicate of bug: 1798111
Resolution: --- → DUPLICATE
Flags: needinfo?(gijskruitbosch+bugs)
You need to log in before you can comment on or make changes to this bug.