1798111 - Certificate Manager > Servers in about:preferences#privacy do not align nicely

Status: RESOLVED FIXED

(Firefox :: Site Identity, defect)

Description

[Fanolian]

Attachment: Certificate Manager.png

+++ This bug was initially created as a clone of Bug #1797345 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0
Build ID: 20221028212211

This was mentioned in bug 1797345 but not fixed by D160302 Bug 1797345 - Use width property rather than attribute in permission dialogs and so.

Steps to reproduce

1. Add exceptions to multiple problematic certificates. (see attached screenshot)
2. Go to about:preferences#privacy > Certificate > View Certificates > Servers

Actual result

Values in 2nd+ column do not align nicely. They are probably affected by the length of the value in the previous column.

Expected result

Every column lines up properly.

Regression

Last good Nightly: 2022-10-19
First bad Nightly: 2022-10-20
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a1297d435b3fddcb752141a4d6e95693b12734a6&tochange=59fa65e9da080d96cf90d9c99a458372b8d58b4d

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=60a8d6f734e902102d87b8b1bd15b62bb4ba5ebe&tochange=6c60375237864880161d4a8915408e68ec28d1e3

This is regressed by D159690 - Use modern flex on in-content pages. from bug 1779695.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1779695, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Uh, sorry for missing that!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779695

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1798111 - Add good enough equalsize=always support for the cert manager. r=Gijs,dao

certManager is the only thing using it (both here and in comm-central,
excluding suite/).

There are better ways to do it generally, so just remove it from elsewhere.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1798111 - Fix column-picker radius. r=Gijs,dao

border: none is not enough apparently.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a68cb6d3d3f0
Add good enough equalsize=always support for the cert manager. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a6851d1e10
Remove an unused variable.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9cc6ac93826
Fix column-picker radius. r=dao

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a68cb6d3d3f0
https://hg.mozilla.org/mozilla-central/rev/88a6851d1e10
https://hg.mozilla.org/mozilla-central/rev/e9cc6ac93826