1683330 - NVDA screen reader doesn’t read the print preview options

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• Firefox 86.0a1 (BuildId:20201218095607)
• Firefox 85.0b4 (BuildId:20201220193140) - Since the regressor got uplifted.

Affected platforms

• Windows 10 64bit (NVDA version 2020.3)

Steps to reproduce

1. Launch Firefox.
2. Open a random webpage
3. Hit CTRL + P in order to open the print preview.
4. Tab through the available print preview options.

Expected result

• NVDA reads all the available print preview options.

Actual result

• NVDA doesn’t read the print preview options.

Regression Range

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=db7c7820bd657d7baa76a0ef5b1ca7266a2edbe6&tochange=4d61fef7427251393af68f4b2ef4fe60b4ed5fe3
• Possible regressor: Bug 1682692

Notes

• Also, it seems that, sometimes, the focus is put behind the actual print preview (on the actual webpage).
• [Suggested Severity] I think that S2 fits for this issue.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hello Eitan,

It seems that mozregression pointed out Bug 1682692 for causing this regression.

Can you please take a look?

Thank you!

Comment 2

[Blake Winton (:bwinton) (:☕️)]

(Adding the [print2020_v86] whiteboard tag so that it stays on our radar…)

Comment 3

[Eitan Isaacson [:eeejay]]

Indeed the print dialog is not getting inserted into the accessible tree. I'll take a look.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r?morgan!

This change that was introduced in bug 1682692 was not actually tested
and is unrelated to the fix. I thought that this was more correct, and I
added it. But this change should be reverted.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5d011725ca9
Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r=yzen

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d5d011725ca9

Comment 7

[Emil Ghitta, QA [:emilghitta]]

It seems that this issue affects Firefox 85.0b4 (BuildId:20201220193140) as well since Bug 1682692 (regressor) got uplifted.

Comment 8

[Emil Ghitta, QA [:emilghitta]]

I can confirm that this issue is verified fixed using Firefox 86.0a1 (BuildId:20201221093813) on Windows 10 64bit with NVDA version 2020.3.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 10

[Eitan Isaacson [:eeejay]]

Comment on attachment 9194028 [details]
Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r?morgan!

Beta/Release Uplift Approval Request

• User impact if declined: Print dialog will no longer be accessible to screen readers
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: With NVDA or VoiceOver, open the print dialog. Note that the print dialog is spoken and accessible.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This reverts a small unwarranted change from a previous patch.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9194028 [details]
Bug 1683330 - Revert skipping inserted node when using TreeWalker.Next in insertion iterator. r?morgan!

approved for 85.0b5

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d843f5079d0e

Comment 13

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 85.0b6 (BuildId:20210107185759) on Windows 10 64bit with NVDA & macOS 10.14 with VoiceOver.