Closed Bug 1683410 Opened 3 years ago Closed 3 years ago

nsThreadManager's thread shutdown check should be atomic

Categories

(Core :: XPCOM, task)

Product:
Core
Component:
XPCOM
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1683410 - Make sShutdownComplete atomic
48 bytes, text/x-phabricator-request
Details | Review

This is accessed offthread when threads are destroyed and set when nsThreadManager shuts down, and as noted by tsan it's capable of racing. The easiest fix is to just make sShutdownComplete atomic.

This is changed on the main thread by nsThreadManager and should probably just be made atomic.

Assignee: nobody → kwright
Status: NEW → ASSIGNED

Also filed Bug 1683407 for this

Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee1e88f47db9
Make sShutdownComplete atomic r=xpcom-reviewers,mccr8

https://hg.mozilla.org/mozilla-central/rev/ee1e88f47db9

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: