1683578 - [wayland] Tooltips occasionally stop showing

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect, P2)

Description

[Jan Alexander Steffens [:heftig]]

It occasionally happens that tooltips (e.g. on tabs) stop showing. This is not a new problem.

I often notice this together with Drag and Drop being broken (bug 1622107).

I'm using GNOME (Wayland, WR, currently Mutter 3.38.2-4-g00e247ed7, GTK 3.24.24).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1880387

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1683578 [Wayland] Provide better log for window types, r?jhorak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22ee3afb3389
[Wayland] Provide better log for window types, r=jhorak

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/22ee3afb3389

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1683578 [Wayland] Rename LockedScreenRect to MozContainerRect to explicitly state it's MozContainer size, r?jhorak

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1683578 [Wayland] Rename mBufferPendingCommit to mWLBufferIsDirty to explicitly state wl_buffer state, r?jhorak

Depends on D104709

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1683578 [Wayland] When MozContainer and wl_buffer size does not match, reset/flush all pending drawings, r?jhorak

• When there's cached drawing from previous rendering and widget size changes, we can't paint the cached drawings.
  Instead create a new wl_buffer with size of MozContainer and clear the cache.

Depends on D104710

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1683578 [wayland] Use wl_surface ID instead of wl_surface address when check for stored frame callback, r?jhorak

Depends on D104711

Comment 9

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=f0cf969706e65fb0eef7863c6378a85eab50b850&selectedTaskRun=H5_-YIpJRJiMFtFsrmzgow.0

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eaef43a5b56
[Wayland] Rename LockedScreenRect to MozContainerRect to explicitly state it's MozContainer size, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/01a9329d6b36
[Wayland] Rename mBufferPendingCommit to mWLBufferIsDirty to explicitly state wl_buffer state, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/60bc4d9b8e64
[Wayland] When MozContainer and wl_buffer size does not match, reset/flush all pending drawings, r=jhorak
https://hg.mozilla.org/integration/autoland/rev/688f02934335
[wayland] Use wl_surface ID instead of wl_surface address when check for stored frame callback, r=jhorak

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7eaef43a5b56
https://hg.mozilla.org/mozilla-central/rev/01a9329d6b36
https://hg.mozilla.org/mozilla-central/rev/60bc4d9b8e64
https://hg.mozilla.org/mozilla-central/rev/688f02934335

Comment 12

[Jan Alexander Steffens [:heftig]]

I've just had missing tooltips again, in a build of https://hg.mozilla.org/mozilla-central/rev/1941f4130b28b8b5863b2af402602d3ef5614d5e.

Comment 13

[Jan Alexander Steffens [:heftig]]

Just had it happen again (Nightly 0abd3454600d); D&D was broken as well.

As in https://bugzilla.redhat.com/show_bug.cgi?id=1880387#c3, opening certain attached dialogs seems to restore both D&D and tooltips. The "Bookmark All Tabs" dialog (Ctrl+Shift+D) worked for this purpose, while "Open File" (Ctrl+O) did not.

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Patches for D&D are at Bug 1635757.
Do you mean you see the missing tooltips with the patches above?
Thanks.

Comment 15

[Martin Stránský [:stransky] (ni? me)]

btw. what do you mean with broken D&D? It's drag of tab and creating new Firefox window or D&D of some content like text/images?

Comment 16

[Jan Alexander Steffens [:heftig]]

Do you mean you see the missing tooltips with the patches above?

Yes.

btw. what do you mean with broken D&D? It's drag of tab and creating new Firefox window or D&D of some content like text/images?

Dragging can't be started, no matter the source. This is the "See Also" bug 1622107. It seems that tooltips being missing and dragging being broken always coincide here.

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Okay, let's move to bug 1622107 then.

As for the tooltips - I expect there isn't a simply way how to reproduce it, correct? I'd need a log of that but it may be difficult to get one when it happens only sometime.

Comment 18

[Jan Alexander Steffens [:heftig]]

Yes, correct.

Comment 19

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 20

[Jan Alexander Steffens [:heftig]]

I don't remember encountering this for a while. I think it might have been fixed together with bug 1622107.

Comment 21

[Martin Stránský [:stransky] (ni? me)]

Thanks.