1683642 - legacySAXResponse._oncompletederror is not a function

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Magnus Melin [:mkmelin]]

TypeError: legacySAXResponse._oncompletederror is not a function CalDavRequest.jsm:554:35
get listener/get/< resource:///modules/caldav/CalDavRequest.jsm:554

Not sure what effect it has, but some errors will not be handled correctly.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1683642_oncompletederror_typo.patch

Fix typo.

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9194197 [details] [diff] [review]
bug1683642_oncompletederror_typo.patch

Oh dear. I wish we had some kind of automated check that says "hey, this word doesn't appear anywhere else in your patch/the code, is it right?"

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/15ed46875be2
fix type that causes "legacySAXResponse._oncompletederror is not a function". r=darktrojan

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9194197 [details] [diff] [review]
bug1683642_oncompletederror_typo.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1546606
User impact if declined: error situations for caldav may be badly handled
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): Not risky. One char type fix.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9194197 [details] [diff] [review]
bug1683642_oncompletederror_typo.patch

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 85.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/7d18db988333

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9194197 [details] [diff] [review]
bug1683642_oncompletederror_typo.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.6.1:
https://hg.mozilla.org/releases/comm-esr78/rev/d2b9c25bb995