1683810 - The display size in MVM for popup window is often never updated

Status: NEW

(Core :: Layout, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

From bug 1683612 comment 12;

(In reply to Timothy Nikkel (:tnikkel) from comment #11)

Does the display size change later to a non-zero value? I would hope it does.

If the case of the scrollbar appears properly, the answer is yes, the display size was initially (0, 0) and it becomes a proper size. But in the case of the problem case, it seems the display size will never be resized correctly as far as I can tell.

Presumably this may be a problem when we want desktop zoom feature in popup window.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I did track down this a bit. So what happens when the popup window size is changed is; nsDocumentViewer::SetBoundsWithFlags gets called, then we run though this code path, thus we call nsIFrame::InvalidateFrame.

But unfortunately, to set the display size in MVM it doesn't work, we need to call PresShell::ResizeReflow instead. But ResizeReflow checks UsesMobileViewportSizing(), which kind of makes sense because we don't need to trigger auto-shrink machinery on desktop. Maybe we can directly change MobileViewportManager::mDisplaySize from nsDocumentViewer::SetBoundsWithFlags? It looks awkward though.

Comment 2

[Timothy Nikkel (:tnikkel)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)

I did track down this a bit. So what happens when the popup window size is changed is; nsDocumentViewer::SetBoundsWithFlags gets called, then we run though this code path, thus we call nsIFrame::InvalidateFrame.

But unfortunately, to set the display size in MVM it doesn't work, we need to call PresShell::ResizeReflow instead. But ResizeReflow checks UsesMobileViewportSizing(), which kind of makes sense because we don't need to trigger auto-shrink machinery on desktop. Maybe we can directly change MobileViewportManager::mDisplaySize from nsDocumentViewer::SetBoundsWithFlags? It looks awkward though.

The SetWindowDimensions call in nsDocumentViewer::SetBoundsWithFlags should result in ResizeReflow getting called eventually, no?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

No, because in the case the size is same, it's this condition.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

No, because in the case the size is same, it's this condition.

Then here.

Comment 5

[Timothy Nikkel (:tnikkel)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #4)

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)

No, because in the case the size is same, it's this condition.

Then here.

Okay, so the view has the right size but the presshell does not. Should we inform the MVM of the (potential) size change in nsDocumentViewer::SetBoundsWithFlags where we call InvalidateFrame so that it can update?