Open Bug 1803631 Opened 2 years ago Updated 8 months ago

Scrollbar in webextension popup does not display correctly

Categories

(Core :: Layout: Scrolling and Overflow, defect, P3)

defect

Tracking

()

Tracking Status
firefox-esr102 --- wontfix
firefox107 --- wontfix
firefox108 --- wontfix
firefox109 --- fix-optional

People

(Reporter: kernp25, Unassigned)

References

(Depends on 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

801 bytes, application/x-zip-compressed
Details
1.74 MB, video/mp4
Details
Attached file popup.zip

The popup has a height of 400px. But the webpage that loaded in the popup (replacing the popup.html) has a bigger height.

This is a bug in Firefox?

Flags: needinfo?(dholbert)
Attached video firefox_vr3dSTGXXO.mp4

Aha, I misunderstood the issue. You're pointing out that the scrollbar can't scroll to the bottom of the scroll track. I can reproduce that, and that does indeed seem like a bug.

Status: UNCONFIRMED → NEW
Component: XUL → Layout
Ever confirmed: true

This seems a lot like the situation in bug 1762569, FWIW.

See Also: → 1762569

This is a regression. Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3ff8ac39b364436a63b387f445899a7db0d3ddd8&tochange=fa3677b2a1e568a0831c7f0a1507cd9972bdd420
In that range, I suspect this would've been fallout from Bug 1718012 ("Call UpdateSizesBeforeReflow only for resize reflow cases...")

hiro, maybe you can take a look here?

To be extra clear, here are the STR:

  1. Visit about:debugging#/runtime/this-firefox
  2. Click "Load Temporary Add-on"
  3. Choose a locally-saved copy of the reporter's attached popup.zip minimal extension.
  4. Click the extension icon that appears on your toolbar.[i]
  5. If the popup stays blank for more than a few seconds[ii], click the extension button again to close it, and then click it again to open it.
  6. After https://www.iana.org loads in the popup, try to scroll the page all the way to the end (e.g. with mousewheel, or by clicking and dragging scrollbar).

EXPECTED RESULTS:
When you reach the bottom (i.e. you can't scroll anymore), the scrollbar thumb should also reach the bottom of its scrollbar track.

ACTUAL RESULTS:
When you reach the bottom (i.e. you can't scroll anymore), the scrollbar thumb has not yet reached the bottom of its scrollbar track. It's as if the scrollbar track thinks there's more scrollable overflow than there actually is.

Notes:
[i] As hinted at in the beginning of comment 2: in recent Nightlies, the extension icon may instead be a menu-entry in a "unified extensions" menu.
[ii] In older nightlies (until ~April 2022), the popup usually just stays blank for me the first time that I open it. But if I close & reopen it again, it populates as-expected.

Flags: needinfo?(hikezoe.birchill)
Regressed by: 1718012

(I haven't debugged the specific case yet)

Blocks: 1493208
See Also: → 1683810

(In reply to Daniel Holbert [:dholbert] from comment #3)

Aha, I misunderstood the issue. You're pointing out that the scrollbar can't scroll to the bottom of the scroll track. I can reproduce that, and that does indeed seem like a bug.

Yes! Sorry, i was not clear enough. The scrollbar in the popup is completely broken.

Set release status flags based on info from the regressing bug 1718012

Okay, I am going to make this bug depend on bug 1683810.

In the case of the extension in comment 0, the document in question doesn't have meta viewport tags, thus this UsesMobileViewportSizing returns false. But MobileViewportManager's display size is supposed to be updated via the RequestReflow call in the if (UsedMobileViewportSizing()) clause.

Bug 1683810 comment 5 would be a solution, but only if the nsDocumentViewer::mBounds is changed by reflows for the document itself such as popup window contents.

Depends on: 1683810
Flags: needinfo?(hikezoe.birchill)
See Also: 1683810

The severity field is not set for this bug.
:jwatt, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jwatt)
Component: Layout → Layout: Scrolling and Overflow
Flags: needinfo?(jwatt)
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: