168408 - [typeaheadfind] backspace after bad character should erase that character

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P3)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Steps to reproduce:

1. go to the mozilla homepage
2. type 'm' 'o' 'z'

The first link containing 'mozilla' is selected by typeahead find

3. type 'z'

the statusbar now says 'Could not find link: "mozz"'

4. type 'i'

It would be nice if typeahead search after step 3 dropped the character that
caused the search to fail, so that i wouldn't have to delete it myself but could
continue to search immideatly.

Since the UI gives me an errorfeedback when pressing the second 'z' (by playing
the 'errorsound') it should also ignore the keypress.

Expected behaviour:
in step 4 typeahead should search for 'mozi' and highlight the appropriate link

Actual behaviour:
in step 4 typeahead searches for 'mozzi' and fails


(yes, i'm well aware the some people might want the current behaviour, but i
thought i should at least raise the discussion :) )

Comment 1

[Aaron Leventhal]

-> Keyboard nav

Comment 2

[Jesse Ruderman]

I think it's better to add the character so that hitting backspace doesn't do
something unexpected.  I often hit backspace in normal typing without thinking
and without looking at the screen because I can tell when my fingers have gotten
ahead of me.

Comment 3

[Aaron Leventhal]

I have a fix for this in bug 167921 that has the best of both worlds. It makes
backspace clear the incorrect key after it's typed, but also lets a new good
character also clear the bad char, as it does now.

Comment 4

[Aaron Leventhal]

Changing summary, to reflect my plans to fix the problem posed by this bug. 

Comment 5

[Aaron Leventhal]

checked in

Comment 6

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.09.26.08 mozilla trunk bits.