Extension shortcuts should be possible to be set to any key, not just alphabetic keys which exist in the same place in the english ANSI layout
Categories
(Toolkit :: Add-ons Manager, defect, P5)
Tracking
()
People
(Reporter: ben.daetwyler, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0
Steps to reproduce:
Firefox 84.0 x64 on Pop! OS 20.10 (ubuntu clone) with X11. When you go into 'Manage Extension Shortcuts' and want to add a shortcut. It should be possible to add any key to a shurtcut, not just the keys which appear on a ANSI layout keyboard in the same place as your (whichever you are currently using) keyboard.
I for e.g.s. am running a ISO CH-Layout and want to add [CTRL] + [<] to an extension shortcut.
Actual results:
You can't set the shortcut to any key which isn't in the same place on a ANSI layout keyboard.
Expected results:
Firefox should take any key (for e.g.s. also [<], ['] key) for a shortcut
Reporter | ||
Comment 1•4 years ago
|
||
I am glad to help if any info is needed on my part. Pls shoot me a msg.
Reporter | ||
Comment 2•4 years ago
|
||
Also I can reproduce this on my Windows 10 machines (also FF 84.0 and 84.0.1, both x64).
Reporter | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
Updated•4 years ago
|
Comment 4•4 years ago
|
||
The set of keys are hardcoded to a subset of all possible keys, to ensure that extensions can choose keys that are supported by every keyboard.
- Permitted values for the
commands
extension API: https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/toolkit/modules/ShortcutUtils.jsm#233-235 about:addons
: https://searchfox.org/mozilla-central/rev/f8a41209af503016e78278774052d48d8c52b91c/toolkit/mozapps/extensions/content/shortcuts.js#58-128- Extension developer documentation: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands#Shortcut_values
This feature request basically asks for more supported keys. I wonder whether this is feasible.
Updated•4 years ago
|
Description
•