1684485 - Convert calendar tests to run in UTC by default

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Geoff Lankow (:darktrojan)]

We've added a bunch of tests recently which set the time zone preference to UTC and then change it back again after the test. It would be better if all of the tests run in UTC by default, which they effectively already do on the CI.

This does raise a problem running on developers' computers which probably aren't in UTC, however if we are careful to use the UTC variants of the Date object's methods, the problem goes away. I'd like to introduce linting rules to enforce that but it's probably more effort than it's worth.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1684485 - Convert calendar tests to run in UTC by default. r?lasana

Changes the test manifests, and uses of the Date object to use UTC.

Depends on D100537

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f364a5426070
Convert calendar tests to run in UTC by default. r=lasana

Comment 3

[Lasana Murray]

Question: Should this be uplifted to 78 so future tests don't break?

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1684485-calendar-tests-utc-esr78.diff

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: none
Testing completed (on c-c, etc.): this bug landed in v86
Risk to taking this patch (and alternatives if risky): none, this is only for tests

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1684485-calendar-tests-utc-esr78.diff

Gah, forgot to update the patch after fixing a typo.

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: none
Testing completed (on c-c, etc.): this bug landed in v86
Risk to taking this patch (and alternatives if risky): none, this is only for tests

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9201935 [details] [diff] [review]
1684485-calendar-tests-utc-esr78.diff

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.8.0:
https://hg.mozilla.org/releases/comm-esr78/rev/2567d82f537c