1670227 - Windows time zone lookup code no longer necessary

Status: RESOLVED FIXED

(Calendar :: Internal Components, enhancement)

Description

[[e-mail]]

When guessing the time zone, the zone retrieved from Windows is looked up in a custom lookup file to be converted to a standard time zone. However, Lightning's time zone service can already look up Windows time zone names, so this is unnecessary. Additionally, Lightning only stores the canonical time zone name in preferences anyway. Also, there's still some old Windows XP time zone lookup code, which is now obsolete.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

I believe zones.json is generated by the timezone upgrade script, can you double check if running it would overwrite the custom changes you've made?

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 9180664 [details] [diff] [review]
Proposed patch

Would appreciate a response on the former comment, please feel free to re-request review when you have time.

Comment 4

[[e-mail]]

My apologies for not responding earlier.

By my reading of the code, the timezone update script only ever merges in new aliases, so it should be fine, but I'd like to double-check with the last person who touched the script, in case they are more familiar with it.

Comment 5

[Geoff Lankow (:darktrojan)]

Yes, I think that's fine, we've added aliases in the same way before.

While we're here, can we please get rid of that archaic way of checking the OS is Windows (CalTimezoneService.js)?

Comment 6

[[e-mail]]

Attachment: Use AppConstants.platform == win

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1e1fdb344d12
Manual lookup of Windows NT time zone name is unnecessary. r=Fallen

Comment 8

[Geoff Lankow (:darktrojan)]

Hope you don't mind me landing this before landing was requested. :-)

Comment 9

[Geoff Lankow (:darktrojan)]

test_alarmutils.js didn't like that. We're getting Z added to the end of iCal strings. My guess is the zone is now correctly being set to UTC instead of Africa/Abidjan like it used to be, but I can't see it in the log to confirm. Bug 1684485 will fix this problem, so I'm not inclined to do anything about it now.