1684526 - The text select cursor is wrongly displayed when hovering the titles and descriptions in the Customization panel

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: text select cursor is wrongly displayed when hovering strings from the panels.gif

[Affected versions]:

• Firefox Nightly 86.0a1, BuildID 20201228205313
• Firefox Beta 85.0b4, BuildID 20201220193140

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Prerequisites]:

• Have a new Firefox profile.
• Have the browser.newtabpage.activity-stream.newNewtabExperience.enabled pref set to true.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab and click the "Personalize" button.
3. Hover the titles or descriptions of the options and observe the cursor.

[Expected results]:

• The cursor (pointer) remains unchanged.

[Actual results]:

• The cursor is changed from pointer to text select.

[Additional notes]:

• The issue is NOT reproducible with the sponsored checkboxes.
• Attached a screen recording of the issue.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1684526 - Cursor default for all of Customize Menu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73141dc5df43
Cursor default for all of Customize Menu. r=prathiksha

Comment 3

[Erica Wright [:ewright]]

Comment on attachment 9199085 [details]
Bug 1684526 - Cursor default for all of Customize Menu.

Beta/Release Uplift Approval Request

• User impact if declined: we will be doing test on this menu in 86, it will appear less professional and polished if the cursor chnages to the text cursor.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): very low, CSS 1 line change
• String changes made/needed: none

Comment 4

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9199085 [details]
Bug 1684526 - Cursor default for all of Customize Menu.

Low risk, approved for 86 beta 2 if it lands on mozilla-central without issue before the gtb, thanks.

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ac64234f659c

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/73141dc5df43

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

@ewright, it looks like the cursor is still changed for descriptions, are we going to plan to change those as well? If so, are we going to reopen this bug or should I log a different one for the remaining behavior?
I checked the behavior on the latest Firefox Nightly 87.0a1 (BuildID 20210127093943) and the latest Beta 86.0b2 (BuildID 20210126185730) using Windows 10, macOS 10.15, LinuxMX 4.19.

Comment 8

[Erica Wright [:ewright]]

(In reply to Ciprian Muresan [:cmuresan], Ecosystem QA from comment #7)

@ewright, it looks like the cursor is still changed for descriptions, are we going to plan to change those as well? If so, are we going to reopen this bug or should I log a different one for the remaining behavior?
I checked the behavior on the latest Firefox Nightly 87.0a1 (BuildID 20210127093943) and the latest Beta 86.0b2 (BuildID 20210126185730) using Windows 10, macOS 10.15, LinuxMX 4.19.

Could you check this again? We had some bundling issues which made this change not take effect.

Comment 9

[:prathiksha]

Could you check this again? We had some bundling issues which made this change not take effect.

I think this effect won't exist in beta until Bug 1687970 gets uplifted. But since Bug 1687970 has landed in Nightly, it should be verifiable on Nightly for now.

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the mouse cursor does NOT change from pointer to text select while hovering any of the strings in the Customization panel with the steps provided in the description, using Firefox Beta 86.0b4 (Build ID: 20210131185630) and Firefox Nightly 87.0a1 (Build ID: 20210131211743) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04