1684611 - Move Forms from debugQA to Composer

Status: RESOLVED FIXED

(SeaMonkey :: Composer, enhancement)

Description

[Ian Neal]

Forms should become part of the Insert Menu in Composer rather than being in debugQA.
Any adding of a toolbar button should be in a follow-up bug.
Also see bug 207217

Comment 1

[Ian Neal]

Attachment: 1684611-insert-form-2537.patch [pushed in comment 8 target 2.53.7]

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no easy way to insert forms
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 18 strings moved from debugQA to editor that will need to be localised

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: editoricons-classic.png

As discussed via irc. First round. I think the middle one needs a bit of a lighter gray but can be adjusted after a wip patch shows it.

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: editoricons-small-classic.png

Might need a 1px transparent border but lets first look at it.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: editoricons-classic.png

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: editoricons-small-classic.png

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: editoricons-classic.png

Order for the new items was incorrect and accidently overwrote image in the upper left corner

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9194999 [details] [diff] [review]
1684611-insert-form-2537.patch [pushed in comment 8 target 2.53.7]

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/61f10dae8a67
Move Forms from debugQA to Composer. r=frg

Comment 9

[Ian Neal]

Attachment: 1684611-formButton-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: no form Button
Testing completed (on m-c, etc.): 2.53.8
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 2 new strings

Comment 10

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9206513 [details] [diff] [review]
1684611-formButton-2538.patch

LGTM

Bigger NIT for followup bug: Ugly new classic icon needs to be replaced.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/751a3034c20b
Move Forms from debugQA to Composer - add toolbar button. r=frg

Comment 12

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7d8a883b9f56c2d4034918b2975a281c2b023c55
Move Forms from debugQA to Composer. r=frg a=frg
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/53367fc9e45c1a087236cac050b1a0f810bba686
Move Forms from debugQA to Composer - add toolbar button. r=frg a=frg