Closed
Bug 1684638
Opened 4 years ago
Closed 4 years ago
WebGLShaderValidator.cpp: do not use 'else' after 'return'
Categories
(Core :: Graphics, task)
Core
Graphics
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: nirmay, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1684637 +++
Filling as a good first bug to learn workflows.
do not use 'else' after 'return'
https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/dom/canvas/WebGLShaderValidator.cpp#101-106
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → nirmay.dhruv
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9195160 -
Attachment description: Bug 1684638 - Removed 'else' after 'return'. r?handyman → Bug 1684638 - Remove 'else' after 'return' in dom/canvas/WebGLShaderValidator.cpp.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/577761f8c32a
Remove 'else' after 'return' in dom/canvas/WebGLShaderValidator.cpp. r=jgilbert
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•