1684648 - nsHttpHeaderArray.cpp: do not use 'else' after 'continue'

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1684647 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'continue'
https://searchfox.org/mozilla-central/rev/809ac3660845fef6faf18ec210232fdadc0f1ad9/netwerk/protocol/http/nsHttpHeaderArray.cpp#295-303

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[Ashish John]

I am new to contributing can I work on this

Comment 2

[CHAITANYA S JHA]

Hello!
I just added the patch and seems that I haven't been assigned yet.
Also what should I write in the commit message in place of a reviewer?

Comment 3

[CHAITANYA S JHA]

Attachment: Bug 1684648 nsHttpHeaderArray.cpp: do not use 'else' after 'continue' r?Sylvestre

Comment 4

[CHAITANYA S JHA]

https://phabricator.services.mozilla.com/D100628

Comment 5

[CHAITANYA S JHA]

YaY!

Comment 6

[Nirmay Dhruv [:nirmay]]

Attachment: Bug 1684648 - Removed 'else' after 'continue'. r?agi,Ehsan

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89adfb937c59
nsHttpHeaderArray.cpp: do not use 'else' after 'continue' r=necko-reviewers,kershaw

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/89adfb937c59