Closed Bug 1684660 Opened 4 years ago Closed 3 years ago

Bogus tag in profiler panel.

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: emilio, Unassigned, Mentored)

References

(Regression)

Details

(Keywords: regression)

<space flex="1">, introduced in bug 1597378, seems bogus. The <space> tag doesn't seem to exist, and should probably be a <spacer>? Or if you just want a regular box, then it should probably be an <hbox> or something.

This lives here now.

This was reported by aminomancer in #introduction, it might be a good first bug or such :)

Flags: needinfo?(gtatum)

Yeah, this looks like a mistake and it can be removed.

Flags: needinfo?(gtatum)
Severity: -- → S4
Priority: -- → P3
Mentor: felash

I would love to work on this, seems like a minor issue that could help build my knowledge of the codebase.

Hey, thanks for your message!
But it looks like it's been removed already... See https://searchfox.org/mozilla-central/rev/a9e0a3f5e5f7cde941d419db967997aaa1f06b0f/browser/base/content/appmenu-viewcache.inc.xhtml#273-278

I'm closing this bug as a result!

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.