1684909 - Implement most of the remaining bits of image-set().

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684909 - Implement source selection for image-set. r=#style

This is based on the logic in ResponsiveImageSelector::SelectImage (just
simplified because there's no viewport-dependent widths here).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684909 - Don't allow to parse image-set(none). r=#style

none is not technically part of the <image> syntax. Tests in following
patches.

Depends on D100698

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684909 - Make rendering aware of image-set(). r=#layout-reviewers

Depends on D100699

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684909 - Add and adjust image-set tests / test expectations. r=#style

The tests uncover two things:

• cursor: image-set() doesn't work, because there's no <image> in the
  spec: https://drafts.csswg.org/css-ui-4/#cursor

• content: image-set() similarly doesn't work. Though in this case the
  spec does call for it to work.

The later doesn't work because we don't support the whole <image> syntax
in content (so, we don't support content: linear-gradient or so on).
That seems like a separate issue to fix (WebKit does support this).

The former should probably also work (though WebKit only supports URLs
and not other images like gradients... will file a spec issue).

Depends on D100700

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684909 - Enable image-set by default on Nightly builds. r=#style

Seems good enough for experimental usage.

Depends on D100701

Comment 6

[Sebastian Zartner [:sebo]]

Could you make the summary of this bug more distinct to bug 1107646? It's not clear what's the difference between them or why it needs a separate bug.

I've created bug 1684958 for adding support for the whole <image> syntax for content.

Besides that, I want to thank you for implementing image-set(), Emilio! I was already waiting for that. Y feliz año nuevo!

Sebastian

Comment 7

[Emilio Cobos Álvarez (:emilio)]

(In reply to Sebastian Zartner [:sebo] from comment #6)

Could you make the summary of this bug more distinct to bug 1107646? It's not clear what's the difference between them or why it needs a separate bug.

Gave that a shot :)

Besides that, I want to thank you for implementing image-set(), Emilio! I was already waiting for that. Y feliz año nuevo!

Np, happy new year too :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a333364a1f
Implement source selection for image-set. r=boris
https://hg.mozilla.org/integration/autoland/rev/f00b50981640
Don't allow to parse image-set(none). r=boris

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f3a333364a1f
https://hg.mozilla.org/mozilla-central/rev/f00b50981640

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87862fd7300
Make rendering aware of image-set(). r=dholbert

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a87862fd7300

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c7363d33df3
Add and adjust image-set tests / test expectations. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/d832e4bba362
Enable image-set by default on Nightly builds. r=boris

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95a0aff84061
Update the devtools CSS database.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a37b47ad6bc7
Fix a mochitest that didn't account for image-set.

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c7363d33df3
https://hg.mozilla.org/mozilla-central/rev/d832e4bba362
https://hg.mozilla.org/mozilla-central/rev/95a0aff84061
https://hg.mozilla.org/mozilla-central/rev/a37b47ad6bc7

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/27167 for changes under testing/web-platform/tests

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot