1684921 - Column separator moves wrong column

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Arthur K. (he/him)]

Attachment: separator-issue.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

I was attempting to adjust my date and subject column width.

Actual results:

When I grabbed and held the separator between name and subject columns, the date column moved/adjusted instead of the subject column (see video).

Expected results:

It shouldn't move other columns

Comment 1

[WaltS48 [:walts48]]

I can reproduce in Daily using the same column configuration.

If I reorder them to Subject, From, Date, the Subject and Date columns resize. The From column remains static.

Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0a1 Build ID 20210105104218

Comment 2

[Wayne Mery (:wsmwk)]

I'm seeing this also, on Mac with beta 86. Several accounts, but only happening on one inbox (the default account). I have no idea how to reproduce.

I wonder if it is related to occasionally my column selections get reset.

Comment 3

[klaus]

this goes away in 86 if browser.tabs.remote.autostart is set to false.

Comment 4

[Arthur K. (he/him)]

(In reply to klaus from comment #3)

this goes away in 86 if browser.tabs.remote.autostart is set to false.

This didn't work for me.

Comment 5

[Wayne Mery (:wsmwk)]

I've been seeing this, but only in the last few months.
Aleca indicates this is a core issue, and to be resolved in Thunderbird will require moving to different code.

Comment 6

[Anje]

Set up columns as per image and all is still ok.
Restarted, tried various themes, tested on different accounts, enabled/disabled Folder Pane, but I cannot reproduce in 78.8.0

Comment 7

[klaus]

Anje, this bug specifies 85 and up. It is working fine in my 78 as well.

Comment 8

[Anje]

Whilst the version mentioned 85, my comment was just to confirm that it was not being seen in earlier versions as sometimes this information is useful.

Comment 9

[Alice0775 White]

I can also reproduce the issue on Firefox86 Windows10.

STR:

1. Open Library (Ctrl+Shift+O)
2. Reorder columns by dragging and dropping. i.e., "Name | Location | Tag"
3. Try to change the column width by dragging the separators.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2109cb4b5529c4a82279f6fc73bc40eccc06f132&tochange=d26e05828f37b8229ae9eb88fed03c61ed389ef1

Comment 10

[Alice0775 White]

[Tracking Requested - why for this release]: Broken UI

Comment 11

[Ryan VanderMeulen [:RyanVM]]

IIUC, this only affects Thunderbird, so not tracking for Firefox. I'll take a low-risk fix for uplift if we get one, though.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

It affects FF as well as per comment 9 right?

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684921 - Fix some missing sorts in xul tree / splitter code. r=TYLin,#layout-reviewers

I missed those in bug 1411372. Custom hit-testing code, yay.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ccf4f852042
Fix some missing sorts in xul tree / splitter code. r=TYLin

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1684921 - Factor the "find prev/next sibling accounting for box ordinal", and fix a missing use of it. r=TyLin

I only noticed this via code inspection.

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/6ccf4f852042

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43b719c60744
Factor the "find prev/next sibling accounting for box ordinal", and fix a missing use of it. r=TYLin

Comment 18

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/43b719c60744