1685078 - Support full <image> syntax in list-style-image as per spec.

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

And simplify nsBulletFrame while at it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Support full <image> syntax in list-style-image as per spec. r=#layout-reviewers!,jrmuizel!

This allows supporting image-set(), etc, and simplifies the bullet frame
code significantly, too thanks to two changes:

• Instead of manually managing the image request, use the CSS image
  loader, with the REQUEST_REQUIRES_REFLOW flag, to handle image
  loads correctly. This didn't exist when this code was initially
  implemented, but we can nicely use it now.

• Instead of re-implementing another WebRender command-builder thing,
  we can just reuse the nsImageRenderer code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47c73e5e08a4
Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 47c73e5e08a4 (bug 1685078) for multiple failures related to CSS. CLOSED TREE

Logs:
https://treeherder.mozilla.org/logviewer?job_id=326045577&repo=autoland&lineNumber=3099

https://treeherder.mozilla.org/logviewer?job_id=326045594&repo=autoland&lineNumber=4220

https://treeherder.mozilla.org/logviewer?job_id=326045573&repo=autoland&lineNumber=3039

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=47c73e5e08a49504a7200236010c01ea2a2a6fdb

Backout:
https://hg.mozilla.org/integration/autoland/rev/762cc086cd05a231dbeecad8e80dd6c524838ebc

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Fix test_bullet_animation.html. r=tnikkel

The current test relies on the explicit decoding that we start
triggering unconditionally right now, and which my previous patch
removes:

https://searchfox.org/mozilla-central/rev/519f913527b0d9d5097d290d5731cff6b2991fe0/layout/generic/nsBulletFrame.cpp#1065

Remove the text so that the animation polling stuff detects when the
image loads (otherwise it sees a non-blank paint and starts thinking
that stuff is loaded, taking the reference snapshot too early).

Depends on D100774

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Don't block the load event on image decode + reflow for bullets. r=TyLin

For bullets we don't want to start blocking onload. It shouldn't matter
anyhow but it's simpler and easier not to change behavior.

While at it avoid some expensive includes in ImageLoader.h

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Remove some useless includes from ImageLoader.h. r=TYLin

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Use enum classes and more explicit names for ImageLoader flags. r=TYLin

Depends on D101069

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Refactor some ImageLoader code for legibility / code reuse. r=TYLin

These will make the following patch clearer.

Depends on D101070

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1685078 - Add a flag to reflow when the size is available, and use it for bullets. r=TYLin

Without blocking onload (which preserves behavior before this patch
series) or requiring a decode for stuff like invisible bullets.

Depends on D101071

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66d167aa16ea
Support full <image> syntax in list-style-image as per spec. r=jrmuizel,TYLin
https://hg.mozilla.org/integration/autoland/rev/0da6fc5419b3
Fix test_bullet_animation.html. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/9084c962424d
Remove some useless includes from ImageLoader.h. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/eff6aadf75c0
Use enum classes and more explicit names for ImageLoader flags. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/277a1d56fccd
Refactor some ImageLoader code for legibility / code reuse. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/04b98b03122f
Add a flag to reflow when the size is available, and use it for bullets. r=TYLin

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1771307a8438
Don't return incomplete draw result for errored images.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/329ab5768e51
Correctly keep sync-decoding images.

Comment 14

[Emilio Cobos Álvarez (:emilio)]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/329ab5768e51
Correctly keep sync-decoding images.

Jeff, mind sanity-checking this commit? It's basically ensuring we pass the right flags to nsImageRenderer, which prevents intermittent reftest failures that the sheriffs pinged me about. Should be pretty straight-forward, but ended up touching a bit more code than I initially thought so probably deserves another look.

Comment 15

[Jeff Muizelaar [:jrmuizel]]

Yeah, seems fine.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/645a4d6461ca
More explicitly fall back for broken images, as sync decoding will happily paint blank in that case.

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/66d167aa16ea
https://hg.mozilla.org/mozilla-central/rev/0da6fc5419b3
https://hg.mozilla.org/mozilla-central/rev/9084c962424d
https://hg.mozilla.org/mozilla-central/rev/eff6aadf75c0
https://hg.mozilla.org/mozilla-central/rev/277a1d56fccd
https://hg.mozilla.org/mozilla-central/rev/04b98b03122f
https://hg.mozilla.org/mozilla-central/rev/1771307a8438
https://hg.mozilla.org/mozilla-central/rev/329ab5768e51
https://hg.mozilla.org/mozilla-central/rev/645a4d6461ca

Comment 19

[Rachel Andrew]

Added to release note, docs updated with a non URL example, and a note added to BCD.