Corroborate is set to run but its telemetry is expired
Categories
(Firefox :: General, defect, P2)
Tracking
()
People
(Reporter: agashlin, Assigned: rhelmer)
References
Details
The corroborate.omnijar_corrupted and corroborate.omnijar_mismatch scalars expired in 80, but it seems that it will still run on late idle (bug 1627040) because the pref is still enabled (since bug 1608308). I don't think it has any function independent of the telemetry. Probably the pref should be disabled?
|
||
Comment 1•4 years ago
|
||
Hi Robert, is there an issue filed to renew those expired scalars that we may mark this as a duplicate of?
(or in alternative we may set priority on it?).
|
||
Comment 2•4 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Toolkit::Telemetry' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 3•4 years ago
|
||
(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #1)
Hi Robert, is there an issue filed to renew those expired scalars that we may mark this as a duplicate of?
(or in alternative we may set priority on it?).
I'm not sure we need to keep this around, I believe there's been some newer work that supersedes this too. I'll investigate and get back to this, it's likely we can just remove the corroborate component and the associated probes.
|
||
Updated•4 years ago
|
|
||
Comment 4•3 years ago
|
||
Note that https://searchfox.org/mozilla-central/search?q=omnijar_corrup&path= has no hits so omnijar-corrupted is already gone, but the omnijar_mismatch one is still around, along with some code to do these checks...
|
||
Updated•3 years ago
|
|
|
||
Comment 5•3 years ago
|
||
Hey Doug, since you worked on Bug 1627040. What do you think about this one?
|
||
Comment 6•3 years ago
|
||
I don't have any authority to speak on the continuing value of this, but it is a nontrivial amount of work to be doing for no reason, even if it's now out of the startup path, so I would hope that we're still getting some value out of it.
|
||
Comment 7•3 years ago
|
||
(In reply to Doug Thayer [:dthayer] (he/him) from comment #6)
I don't have any authority to speak on the continuing value of this, but it is a nontrivial amount of work to be doing for no reason, even if it's now out of the startup path, so I would hope that we're still getting some value out of it.
Thanks. Upgrading the severity and priority based on this assessment.
:heycam, as the author of bug 1608308, any thoughts on this?
|
|
||
Comment 8•3 years ago
|
||
Cameron's no longer at Mozilla. I'll renew rhelmer's needinfo request instead.
|
|
||
Comment 9•3 years ago
|
||
(In reply to Robert Helmer [:rhelmer] from comment #3)
I'm not sure we need to keep this around, I believe there's been some newer work that supersedes this too. I'll investigate and get back to this, it's likely we can just remove the corroborate component and the associated probes.
Hey, any update on this?
|
|
Assignee | |
Comment 10•3 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #9)
(In reply to Robert Helmer [:rhelmer] from comment #3)
I'm not sure we need to keep this around, I believe there's been some newer work that supersedes this too. I'll investigate and get back to this, it's likely we can just remove the corroborate component and the associated probes.
Hey, any update on this?
I can go ahead and remove this, thanks for the ping.
Description
•