1608308 - add telemetry for libxul / omni.ja build ID matching to Corroborate.jsm

Status: RESOLVED FIXED

(Firefox :: General, task, P1)

Description

[Cameron McCormack (:heycam)]

One possible cause of bug 1607716 is a version mismatch between libxul and the omni.ja. We can add some telemetry to check if that's the case.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1608308 - Add telemetry to check that the libxul and omnijar build IDs match.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: data review request

Comment 3

[Robert Helmer [:rhelmer]]

Oh, I should mention too that this is only enabled on Nightly currently:

https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#1886

We can go ahead and enable it for beta/release now though, I have been meaning to and haven't gotten around to it yet.

Comment 4

[Chris H-C :chutten]

Comment on attachment 9119956 [details]
data review request

Load-balancing to Megan.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: data review request

Comment 6

[Cameron McCormack (:heycam)]

Attachment: Bug 1608308 - Enable Corroborate.jsm telemetry on release.

And bump the expiration versions on the scalars.

Comment 7

[Robert Helmer [:rhelmer]]

BTW I was just looking over things, and as it happens we disabled the tests after the armagadd-on incident (waiting for the new signing cert to become available since the test uses it to make sure we don't count e.g. an omni jar signed with the AMO cert as valid). So here's a patch for re-enabling that, I don't want this to ride out w/o test coverage :)

Comment 8

[Robert Helmer [:rhelmer]]

Attachment: Bug 1608308 - re-enable corroborator tests

Comment 9

[Cameron McCormack (:heycam)]

Ping for data-review request.

Comment 10

[Robert Helmer [:rhelmer]]

Attachment: Data Collection Renewal for Bug 1608308

Comment 11

[Chris H-C :chutten]

Comment on attachment 9122609 [details]
Data Collection Renewal for Bug 1608308

    Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

    Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---
Result: datareview+

Comment 12

[Chris H-C :chutten]

Comment on attachment 9120381 [details]
data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Scalars.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Scalars.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 80.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :heycam is responsible for renewing or removing the collection before it expires in Firefox 80.

---
Result: datareview+

Comment 13

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67682a3adfee8b3d82ddf63c67dda7a7dc2f6ea6

Comment 14

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=96fb9186f9e48bcaf42225c6f42ceef2a81f0720

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4d8eb6905e1
Add telemetry to check that the libxul and omnijar build IDs match. r=rhelmer
https://hg.mozilla.org/integration/autoland/rev/ce41f6059545
Enable Corroborate.jsm telemetry on release. r=rhelmer
https://hg.mozilla.org/integration/autoland/rev/3239cb4f98c6
re-enable corroborator tests r=heycam

Comment 16

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b254a169b0d3127f018320e48183d8e3fd2910a

Comment 17

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b4d8eb6905e1
https://hg.mozilla.org/mozilla-central/rev/ce41f6059545
https://hg.mozilla.org/mozilla-central/rev/3239cb4f98c6

Comment 18

[Cameron McCormack (:heycam)]

Filed bug 1614541 to investigate the results.