1685748 - Upgrade legacy extension search engines to use the supported extension definition

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

From looking at various data, there are a set of engines in user's profiles where the loadPath looks something like:

jar:[profile]/extensions/<extensionid>.xpi/<filename>.xml

The jar: is optional, and profile may be app instead.

In most of the cases, these are cases where an extension used to define an OpenSearch engine, and then switched to the WebExtension definition but also changed the name of the search engine (e.g. foo -> foo search).

The change of name defeats the code we have to automatically upgrade these engines.

The remaining cases are where an add-on is no longer installed/enabled, but we failed to remove the associated search engine.

By switching these cases to the installed supported WebExtension version, this means that they will be updated to that defined by the WebExtension, and receive any future updates from the same.

If the extension is no longer installed, then we should remove the Search Engine, as we would have done previously.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1685748 - Rewrite test_migrateWebExtensionEngine.js to use better methods for installing the engines under test. r?daleharvey!

Also ensure the default engine remains the same.

Also remove engine3.xml because it is not used.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1685748 - When installing a WebExtension based search engine, migrate existing legacy format definitions even if the name is different. r?daleharvey!

Depends on D103093

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1685748 - Migrate legacy extension search engines to use supported extension definitions. r?daleharvey!

These should generally have been updated previously, but the search service expected a same-name match. We have seen instances where these were different so we should migrate them.

Depends on D103094

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3f573106c1e
Rewrite test_migrateWebExtensionEngine.js to use better methods for installing the engines under test. r=mak
https://hg.mozilla.org/integration/autoland/rev/8ccb7b933d13
When installing a WebExtension based search engine, migrate existing legacy format definitions even if the name is different. r=mak
https://hg.mozilla.org/integration/autoland/rev/5a3f2b7bda73
Migrate legacy extension search engines to use supported extension definitions. r=mak

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f3f573106c1e
https://hg.mozilla.org/mozilla-central/rev/8ccb7b933d13
https://hg.mozilla.org/mozilla-central/rev/5a3f2b7bda73