1685985 - Toolbox error count hides the Toolbox Toolbar Chevron

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Attachment: chevron_partially_hidden.png

STRs:
this will only happen for certain widths, so I will give settings that work for me but it might be different depending on OSes, zoom levels etc.

• in about:config set devtools.toolbox.sidebar.width to "651"
• in about:config set devtools.toolbox.host to "right"
• open devtools
• run console.error(1)

ER: The chevron should be fully visible
AR: The chevron is partially hidden behind the error count

Note, it you try to play with other dynamic buttons (eg the frame picker) they will correctly trigger an update of the toolbar when they get displayed. Handling the error count icon in a more consistent manner as mentioned in https://phabricator.services.mozilla.com/D100668#inline-567164 would probably address this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1109362

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1685985 - [devtools] Refactor browser_toolbox_options_disable_buttons. r=bomsy.

• switch to add_task + registerCleanupFunction
• reorder functions so they match the order they're called in the main function
• remove global variables in favor of explicit parameters
• switch from Promise chains to await where possible

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1685985 - [devtools] Handle error count button like other toolbox buttons. r=jdescottes.

A button configuration is now created from _buildButtons so the error count button
is part of the toolbarButtons property on the toolbox.
An updateErrorCountButton updates the property of the button, and we call it
from the function that updates the error count, from which we also trigger a new
render for the toolbar.

This way updating the error count will go through the overflow logic we have in
the toolbar (to show the chevron or not).

A "side effect" of this is that an item is automatically created in the options
panel to disable the error count button. In order for it to work properly, we
need to add a preference to store its enabled state, as well as a specific
localized string for the input label.

browser_toolbox_error_count is updated to ensure that the error button isn't
displayed if it was disabled in the option panel, even if new errors are emitted.

browser_toolbox_options_disable_buttons was updated to reflect the changes made
to the error count button.

Depends on D101568

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a662cc2614d
[devtools] Refactor browser_toolbox_options_disable_buttons. r=bomsy.
https://hg.mozilla.org/integration/autoland/rev/3ff621cea4dc
[devtools] Handle error count button like other toolbox buttons. r=jdescottes.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1a662cc2614d
https://hg.mozilla.org/mozilla-central/rev/3ff621cea4dc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b549b44b488
Add the "devtools.command-button-errorcount.enabled" pref to Thunderbird. r=mkmelin