1686045 - Middle-clicking links on DuckDuckGo search result triggers popup blocker

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

1. Open https://duckduckgo.com/?t=ffab&q=mozilla&ia=web
2. Middle-click the description part, not the title of the search results

Expected: A tab should be opened
Actual: The popup blocker prevents it

Comment 1

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Hey Emilio, I saw your recent work on transient activation, is this something still interests you?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

This is because duckduckgo is opening the window on a mousedown event. The popup blocker in GetEventPopupControlState determines that mousedown isn't allowed to open the popup (see the popup_allowed_events pref), and thus blocks it.

So in order to fix it we could add mousedown to the events, or duckduckgo could change their event handler to use click or mouseup.

Olli, Masayuki, do you have context on why we block popups on mousedown? I guess it could be annoying if we allowed it on the primary button because it could prevent selection or something, but other than that, for middle-click at least it probably should be allowed?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I don't know.

But according to UserActivation.cpp, mousedown is treated as a user activating action. So, it seems that popup blocker should also allow it.

Edgar?

Comment 4

[Edgar Chen [:edgar]]

I guess we could at least allow popup for mousedown on middle-button.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Bug 1686045 - Part 1: Rewrite popup blocker tests for mouse/pointer event;

And add more tests for different button value.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1686045 - Part 2: Allow popups from mousedown and pointerdown events;

We allow popups on middle button for mouse events, pointer event should just be
consistent with mouse event.

Depends on D101507

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=6565368988e90c2a061a6842be0e32a5ce6277f2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ff2125f9ab0
Part 1: Rewrite popup blocker tests for mouse/pointer event; r=smaug
https://hg.mozilla.org/integration/autoland/rev/3d3c6b9521dc
Part 2: Allow popups from mousedown and pointerdown events; r=smaug

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ff2125f9ab0
https://hg.mozilla.org/mozilla-central/rev/3d3c6b9521dc

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ff2125f9ab0
https://hg.mozilla.org/mozilla-central/rev/3d3c6b9521dc

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Successfully reproduced the issue on Firefox 86.0a1 (2021-01-11) under macOS 10.15.7 following the steps from Comment 0.

The issue is fixed on latest Nightly 87.0a1 (2021-02-03) and Firefox 86.0b5. Tests were performed on macOS 10.15.7, Ubuntu 20.04 and Windows 7.