1686055 - Failure to save OpenPGP attachments that decrypt to binary data

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

The fix from bug 1663169 only works for some attachments.

We need to fix the code to work with attachments that are encrypted binary data, too.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1686055 - Fix decrypting of attachments containing binary data. r=mkmelin

Comment 2

[hyperbolic]

@KaiE

Thank you very much for fixing this! Do you already have an idea when we can expect that change to arrive in TB?

I thought of downloading the two changed source files and replace them in our installations for testing, but I am a little bit reluctant about it because direct download doesn't seem to be offered by the code management system, which probably has its reasons.

Off-topic

There is a bug in phabricator. Clicking on the attachment in your previous comment makes phabricator throw a dialog box with the following error message:

Unhandled Exception ("Exception")
Failed to load file data for changeset ("PHID-FILE-556ijvxmtxjqfsvyqjie").

When we click on "Close" there, the same dialog box opens again, but this time denoting another file. When we click "Close" a second time, the page appears to work normally.

Thanks again, and best regards.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b4674ee363d8
Fix decrypting of attachments containing binary data. r=mkmelin

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9196396 [details]
Bug 1686055 - Fix decrypting of attachments containing binary data. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: cannot decrypt many attachments
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9196396 [details]
Bug 1686055 - Fix decrypting of attachments containing binary data. r=mkmelin

(Beta was cut yesterday so this will automatically be in beta, which should be out in a few days)

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9196396 [details]
Bug 1686055 - Fix decrypting of attachments containing binary data. r=mkmelin

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/9898791a1e52

Comment 8

[bugzilla]

Still unable to DECRYPT AND OPEN attached Jpg. Message: "null undefined"!
11:46:36.603 [Exception... "Component returned failure code: 0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIXPCComponents_Utils.readUTF8URI]" nsresult: "0x80520001 (NS_ERROR_FILE_UNRECOGNIZED_PATH)" location: "JS frame :: resource://gre/modules/L10nRegistry.jsm :: L10nRegistry.loadSync :: line 658" data: no] 2 L10nRegistry.jsm:658:19
11:46:38.986 Successfully loaded OTR library libotr-5.dll from C:\Program Files (x86)\MozillaTB\libotr-5.dll OTRLib.jsm:43:13
11:46:39.016 public keys: 60, secret keys: 0 RNPLib.jsm:247:15
11:46:39.115 Successfully loaded optional OpenPGP library libgpgme-11.dll from system's standard library locations GPGMELib.jsm:59:13
11:46:39.117 gpgme version: 1.14.0 GPGMELib.jsm:231:15
11:47:59.578 cannot decrypt message decryption.jsm:528:15
11:49:04.911 1612954144911 addons.xpi-utils WARN Add-on [e-mail] is not compatible with application version.

Comment 9

[bugzilla]

11:46:35.945 TypeError: singletons is null 3 ActorManagerChild.jsm:297:32

Comment 10

[ThunderFan]

Hello,

The same error ("null undefined") still occurs also for me.
Version: 78.7.1 (32 bits)
It's the same what I've reported here - 1663169 for version 78.6.0 (32-bit).

Best Regards

Comment 11

[bugzilla]

Same message occurs when trying to import an OpenPGP-key from an attachment: "null undefined"!
12:18:52.956 rnp_import_keys failed with rv: 301989888 RNP.jsm:1603:15
12:18:52.959 rnp_op_verify_execute returned unexpected: 268435457 RNP.jsm:985:17

Comment 12

[bugzilla]

The solution is to import the secret key into TB...
The use of External GnuPG in TB does not allow to decrypt attachments!

Comment 13

[Magnus Melin [:mkmelin]]

Please file a new bug to fix it for the case of using an external gnupg key as well.

Comment 14

[ThunderFan]

(In reply to bugzilla from comment #12)

The solution is to import the secret key into TB...
The use of External GnuPG in TB does not allow to decrypt attachments!

Thanks for the hint!

I already had all the keys imported (during the migration from Enigmail to TB) and they didn't work.
However after removing all of them and importing again, decryption started to work.

Best Regards

Comment 15

[bugzilla]

The use of External GnuPG in TB still does not allow to decrypt attachments!

Comment 16

[Kai Engert [:KaiE:]]

(In reply to bugzilla from comment #15)

The use of External GnuPG in TB still does not allow to decrypt attachments!

tracked in bug 1704820