Failure to save OpenPGP attachments that decrypt to binary data when using external GnuPG key
Categories
(MailNews Core :: Security: OpenPGP, defect, P2)
Tracking
(thunderbird_esr78 wontfix, thunderbird_esr91+ fixed, thunderbird93+ fixed)
People
(Reporter: bugzilla, Assigned: KaiE)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr91+
|
Details | Review |
Bug 1686055, Opened 3 months ago Closed 3 months ago, shows this problem.
It still exists using an external gnupg key, see 2012-02-16 01:52 PST by Magnus Melin.
Updated•4 years ago
|
Updated•4 years ago
|
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9ef7f431cd0b
Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 3•3 years ago
|
||
(we don't uplift to 78 unless super critical anymore)
Assignee | ||
Comment 4•3 years ago
|
||
Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin
[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: some users cannot decrypt email attachments
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): very low risk, only affects nonstandard configuration
Comment 5•3 years ago
|
||
Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin
[Triage Comment]
Approve for beta
Comment 6•3 years ago
|
||
bugherder uplift |
Thunderbird 93.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/67140ac4a119
Comment 7•3 years ago
|
||
Probably want to request 91 uplift as well.
Comment 8•3 years ago
|
||
Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin
[Approval Request Comment]
As noted in the beta uplift request, low risk as a small subset of OpenPGP users have such a configuration. Currently on beta.
Comment 9•3 years ago
|
||
Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin
[Triage Comment]
Approved for esr91
Comment 10•3 years ago
|
||
bugherder uplift |
Thunderbird 91.2.0:
https://hg.mozilla.org/releases/comm-esr91/rev/98cd208c07e1
Reporter | ||
Comment 11•3 years ago
|
||
Please tell me how to download Thunderbird 91.2.0 for a test.
Comment 12•3 years ago
|
||
It is not yet available
Reporter | ||
Comment 13•3 years ago
|
||
It is fixed for me in Thunderbird 93.0b5!
Reporter | ||
Comment 14•3 years ago
|
||
Thunderbird 91.2.0 shows this error: 14:41:58.290 cannot decrypt message decryption.jsm:513:15
Reporter | ||
Comment 15•3 years ago
|
||
(In reply to bugzilla from comment #14)
Thunderbird 91.1.2 shows this error: 14:41:58.290 cannot decrypt message decryption.jsm:513:15
Reporter | ||
Comment 16•2 years ago
|
||
Thunderbird 100.0.3 decrypts to unreadable binary:
PNG
IHDR ÝD¾ sRGB ®Îé gAMA ±
üa IDAT8OR
Â0»¡ &a0 2 <à Ã(äúÒ£ëoä½°r½¤Yw²¬%~D^xö 5÷¥l^é{FY5ÔgÀ^5eÑ°. ²p¤® ôÆ33ÄÉjvÞ%Õ¸gèDn\Ð8ÿÐ{âòØ'ê¨8nôNkÉÓé+Ïì3 ßUi.çhÿgÈt uûºfÙúfbÃlTPïy ´ÆmC|¨Ù £¶y%ÄgnP·Þ°ÎÒù«aË!¥7w 9ÈlPóOÿä P6R.ÚJ *¦
)åÔáÇaâ߬5Þ¥â ÝkBä
¹==±Ïè IEND®B`
It should look like this:
‰PNG
IHDR ÝDŒ¾ sRGB ®Îé gAMA ±
üa IDAT8OR
Â0»¡ &a0 “2 <à Ã(äúÒ£ëoä½°r½¤Yw²Š¬%~D^xö’ 5÷¥l^é‘{—’FY5ÔgÀ^5eÑ°•. –²–p¤® ô‰Æ33ÄÉjvÞ%Õ¸gèDn\Ð8‚ÿÐ{âò‡Ø'ê¨8nôNkÉÓ”é+Ïì3 ßUi.çhÿgÈt™ uûšºfÙ€úf„bÃlTPïy ´ÆmC|¨‚Ù £¶y%ÄgnP·”Þ°’ÎÒù«aË!¥7w 9Èl„PóOÿä P6R.Ú˜J *¦
)åÔáÇaâ߬5Þ¥â ÝkBä
–¹=„=±Ïè IEND®B`‚
Assignee | ||
Comment 17•2 years ago
|
||
(In reply to bugzilla from comment #16)
Thunderbird 100.0.3 decrypts to unreadable binary:
You probably refer to 102.x.
What action do you use to decrypt? Are you using the "decrypt and save as" right-click action on an encrypted attachment?
(If yes, that's bug 1780123, which should be fixed soon.)
Reporter | ||
Comment 18•2 years ago
|
||
In Thunderbird 91.9.0 (64-Bit) it workes:
‰PNG
IHDR ÝDŒ¾ sRGB ®Îé gAMA ±üa IDAT8ORÂ0»¡ &a0 “2 <à Ã(äúÒ£ëoä½°r½¤Yw²Š¬%~D^xö’ 5÷¥l^é‘{—’FY5ÔgÀ^5eÑ°•. –²–p¤® ô‰Æ33ÄÉjvÞ%Õ¸gèDn\Ð8‚ÿÐ{âò‡Ø'ê¨8nôNkÉÓ”é+Ïì3 ßUi.çhÿgÈt™ uûšºfÙ€úf„bÃlTPïy ´ÆmC|¨‚Ù £¶y%ÄgnP·”Þ°’ÎÒù«aË!¥7w9Èl„PóOÿä P6R.Ú˜J *¦
)åÔáÇaâ߬5Þ¥â ÝkBä–¹=„=±Ïè IEND®B`‚
Reporter | ||
Comment 19•2 years ago
|
||
I use the "decrypt and save as" right-click action on an encrypted attachment.
This decrypts to unreadable binary in Thunderbird 100.0.3 (64-Bit), but works in 91.9.0 (64-Bit).
Reporter | ||
Comment 20•2 years ago
|
||
Yes, I see it is 102.x. and bug 1780123...
Assignee | ||
Comment 21•2 years ago
|
||
I believe this bug is fixed in 102.2.1, please comment again if you still see this bug.
Description
•