Closed Bug 1704820 Opened 2 years ago Closed 1 year ago

Failure to save OpenPGP attachments that decrypt to binary data when using external GnuPG key

Categories

(MailNews Core :: Security: OpenPGP, defect, P2)

Tracking

(thunderbird_esr78 wontfix, thunderbird_esr91+ fixed, thunderbird93+ fixed)

RESOLVED FIXED
94 Branch
Tracking Status
thunderbird_esr78 --- wontfix
thunderbird_esr91 + fixed
thunderbird93 + fixed

People

(Reporter: bugzilla, Assigned: KaiE)

References

Details

Attachments

(1 file)

Bug 1686055, Opened 3 months ago Closed 3 months ago, shows this problem.
It still exists using an external gnupg key, see 2012-02-16 01:52 PST by Magnus Melin.

Component: General → Security: OpenPGP
Product: Thunderbird → MailNews Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Failure to save OpenPGP attachments that decrypt to binary data → Failure to save OpenPGP attachments that decrypt to binary data when using external GnuPG key
Priority: -- → P2
See Also: → 1663169
See Also: → 1686055
Assignee: nobody → kaie

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9ef7f431cd0b
Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

(we don't uplift to 78 unless super critical anymore)

Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): no
User impact if declined: some users cannot decrypt email attachments
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): very low risk, only affects nonstandard configuration

Attachment #9241246 - Flags: approval-comm-beta?

Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin

[Triage Comment]
Approve for beta

Attachment #9241246 - Flags: approval-comm-beta? → approval-comm-beta+

Probably want to request 91 uplift as well.

Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin

[Approval Request Comment]
As noted in the beta uplift request, low risk as a small subset of OpenPGP users have such a configuration. Currently on beta.

Attachment #9241246 - Flags: approval-comm-esr91?

Comment on attachment 9241246 [details]
Bug 1704820 - Fix buffers to allow decrypting binary attachments with external GnuPG. r=mkmelin

[Triage Comment]
Approved for esr91

Attachment #9241246 - Flags: approval-comm-esr91? → approval-comm-esr91+

Please tell me how to download Thunderbird 91.2.0 for a test.

It is not yet available

It is fixed for me in Thunderbird 93.0b5!

Thunderbird 91.2.0 shows this error: 14:41:58.290 cannot decrypt message decryption.jsm:513:15

(In reply to bugzilla from comment #14)

Thunderbird 91.1.2 shows this error: 14:41:58.290 cannot decrypt message decryption.jsm:513:15

Thunderbird 100.0.3 decrypts to unreadable binary:
PNG

IHDR ÝD¾ sRGB ®Îé gAMA ±
üa IDAT8OR
Â0»¡ &a0 2 <à Ã(äúÒ£ëoä½°r½¤Yw²Š¬%~D^xö’ 5÷¥l^é‘{—’FY5ÔgÀ^5eÑ°•. –²–p¤® ô ‰Æ33ÄÉjvÞ%Õ¸gèDn\Ð8‚ÿÐ{âò‡Ø'ê¨8nôNkÉӔé+Ïì3 ßUi.çhÿgÈt™ uûšºfـúf„bÃlTPïy ´ÆmC|¨‚Ù £¶y%ÄgnP·”Þ°’ÎÒù«aË!¥7w 9Èl„PóOÿä P6R.ژJ *¦)åÔáÇaâ߬5Þ¥â ÝkBä
¹==±Ïè IEND®B`

It should look like this:
‰PNG

IHDR ÝDŒ¾ sRGB ®Îé gAMA ±
üa IDAT8OR
Â0»¡ &a0 “2 <à Ã(äúÒ£ëoä½°r½¤Yw²Š¬%~D^xö’ 5÷¥l^é‘{—’FY5ÔgÀ^5eÑ°•. –²–p¤® ô ‰Æ33ÄÉjvÞ%Õ¸gèDn\Ð8‚ÿÐ{âò‡Ø'ê¨8nôNkÉÓ”é+Ïì3 ßUi.çhÿgÈt™ uûšºfÙ€úf„bÃlTPïy ´ÆmC|¨‚Ù £¶y%ÄgnP·”Þ°’ÎÒù«aË!¥7w 9Èl„PóOÿä P6R.Ú˜J *¦)åÔáÇaâ߬5Þ¥â ÝkBä
–¹=„=±Ïè IEND®B`‚

Flags: needinfo?(kaie)

(In reply to bugzilla from comment #16)

Thunderbird 100.0.3 decrypts to unreadable binary:

You probably refer to 102.x.

What action do you use to decrypt? Are you using the "decrypt and save as" right-click action on an encrypted attachment?
(If yes, that's bug 1780123, which should be fixed soon.)

Flags: needinfo?(kaie)

In Thunderbird 91.9.0 (64-Bit) it workes:
‰PNG

IHDR ÝDŒ¾ sRGB ®Îé gAMA ±üa IDAT8ORÂ0»¡ &a0 “2 <à Ã(äúÒ£ëoä½°r½¤Yw²Š¬%~D^xö’ 5÷¥l^é‘{—’FY5ÔgÀ^5eÑ°•. –²–p¤® ô ‰Æ33ÄÉjvÞ%Õ¸gèDn\Ð8‚ÿÐ{âò‡Ø'ê¨8nôNkÉÓ”é+Ïì3 ßUi.çhÿgÈt™ uûšºfÙ€úf„bÃlTPïy ´ÆmC|¨‚Ù £¶y%ÄgnP·”Þ°’ÎÒù«aË!¥7w9Èl„PóOÿä P6R.Ú˜J *¦)åÔáÇaâ߬5Þ¥â ÝkBä–¹=„=±Ïè IEND®B`‚

Flags: needinfo?(kaie)

I use the "decrypt and save as" right-click action on an encrypted attachment.
This decrypts to unreadable binary in Thunderbird 100.0.3 (64-Bit), but works in 91.9.0 (64-Bit).

Yes, I see it is 102.x. and bug 1780123...

I believe this bug is fixed in 102.2.1, please comment again if you still see this bug.

Flags: needinfo?(kaie)
You need to log in before you can comment on or make changes to this bug.