1686244 - (sw-wr-perf-linear-gradient) sw-wr: nasdaq.com spends lots of time in linear gradients

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

See https://www.nasdaq.com/articles/pirated-academic-database-sci-hub-is-now-on-the-uncensorable-web-2021-01-11

https://share.firefox.dev/38Cln59

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Standalone test case

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1686244 - Accelerate linear gradients in SWGL. r?jrmuizel

For linear gradients, we are currently bottlenecked by looking up a gradient
table entry, doing interpolation, and converting to pixel formats for every
sample.

We can accelerate this by instead looking for contiguous segments of gradient
within the range of entries we need to sample and then interpolating these
as a single gradient. This also enables us to convert to relevant pixel formats
only when setting up this gradient, which greatly reduces the per-pixel processing
down to essentially a shift and add.

To enable this sort of crawling of the gradient table, the output gradients have
been modified such that each entry's step value will equal an adjacent entry's
step value if and only if they are from same gradient. We can ensure this by, in
the very rare case two segments of gradient have the same step, using the equivalent
of nextafter() to imperceptibly alter the value so that the invariant is maintained.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: Bug 1686244 - Accelerate radial gradients in SWGL. r?jrmuizel

The same optimization of looking for merged linear gradients can also be
applied to radial gradients by solving the quadratic equation to check
how large a span we can process within a given merged span. This allows
us to save a bunch of table lookup and some other math in the inner loops.

Depends on D105716

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1686244 - Accelerate nearest repeat filtering in SWGL. r?jrmuizel

Some sites use pixelated image-rendering and/or 1x1 images as color sources.
When we hit these, we fall off the fast-path. Try to handle at least some of
the cases we are finding in the wild.

Depends on D105858

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e97ee33645a
Accelerate linear gradients in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/395458ef80ae
Accelerate radial gradients in SWGL. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/01f66dc6aca4
Accelerate nearest repeat filtering in SWGL. r=jrmuizel

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1686244 - Avoid zero offset in radial gradient.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f0413b1ad6f
Avoid zero offset in radial gradient. r=jgilbert

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6e97ee33645a
https://hg.mozilla.org/mozilla-central/rev/395458ef80ae
https://hg.mozilla.org/mozilla-central/rev/01f66dc6aca4
https://hg.mozilla.org/mozilla-central/rev/8f0413b1ad6f

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #28874 (as of Mon, 22 Feb 2021 21:15:19 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
197%	rasterflood_gradient		windows10-64-shippable-qr	e10s stylo webrender-sw	455.50 -> 1,350.83
179%	rasterflood_gradient		linux64-shippable-qr	e10s stylo webrender-sw	488.33 -> 1,363.50
161%	rasterflood_gradient		macosx1014-64-shippable-qr	e10s stylo webrender-sw	408.08 -> 1,064.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28874

Comment 10

[Lee Salzman [:lsalzman]]

Comment on attachment 9204505 [details]
Bug 1686244 - Avoid zero offset in radial gradient.

Beta/Release Uplift Approval Request

• User impact if declined: Trying to do partial SW-WR rollout on Linux. Would like to avoid people reporting significant performance regressions months down the line.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only impacts SW-WR/Linux. We can abort the rollout if unstable. Adequate time to deal with any bugs.
• String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9204124 [details]
Bug 1686244 - Accelerate linear gradients in SWGL. r?jrmuizel

Approved for 87.0b3.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a35a81c995c0
https://hg.mozilla.org/releases/mozilla-beta/rev/f1551c87765c
https://hg.mozilla.org/releases/mozilla-beta/rev/be0f0e9ba18c
https://hg.mozilla.org/releases/mozilla-beta/rev/86ad69ab8ba3

Comment 13

[Lee Salzman [:lsalzman]]

Attachment: Bug 1686244 - Handle degenerate linear gradients. r?aosmond

This just reorders some checks to fail against NaNs and also checks for finiteness.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7be47f00f8cf
Handle degenerate linear gradients. r=aosmond

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7be47f00f8cf

Comment 16

[Lee Salzman [:lsalzman]]

Comment on attachment 9205247 [details]
Bug 1686244 - Handle degenerate linear gradients. r?aosmond

Beta/Release Uplift Approval Request

• User impact if declined: Fixes potential crashes related to degenerate gradients we discovered in local mochitest runs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just a crash fix for the feature uplift here.
• String changes made/needed:

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9205247 [details]
Bug 1686244 - Handle degenerate linear gradients. r?aosmond

Approved for 87.0b4.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/88b1220bf251