1674524 - (sw-wr-perf-mix-blend) Implement GL_KHR_blend_equation_advanced in swgl

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

This would give us good mixed-blend-mode support. WebRender already has code to use this extension.

Comment 1

[Brad Werth [:bradwerth]]

Attachment: Bug 1674524: Add ADVANCED_BLEND support to brush_mix_blend shader.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1674524 Part 1: Stub in BLEND_KEYs for KHR advanced blend modes.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1674524 Part 1: Add blend mode keys for KHR advanced blend equations.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1674524 Part 2: Implement the KHR advanced blend equations in SWGL.

Depends on D102989

Comment 5

[Brad Werth [:bradwerth]]

Taking myself off the bug -- this one is beyond my capabilities, for now.

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1674524 - implement KHR_blend_equation_advanced in SWGL. r?bradwerth

This patch has a few moving parts. We have to first tell WR that when it
detects the extension that it is actually allowed to use it. We have to make
the glsl-to-cxx translator eat the blend_supports_all_equations layout
qualifier. We have to enable generation of advanced-blend-equation variants
in the SWGL build setup. Then we report the actual extension inside SWGL.
Finally, we actually add all the necessary blend equation enums, hash them
down to a blend key, and implement all the blend modes therein.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f71aafc4e845
implement KHR_blend_equation_advanced in SWGL. r=bradwerth

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f71aafc4e845 (Bug 1674524) for build bustages in src/gl.cc.
https://hg.mozilla.org/integration/autoland/rev/5ef6860a9b17d5cf8ae63670201e199de8906704

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=15ea118b8e5602a20e6b0193ec4535b809b009e0&selectedTaskRun=WkozPtnGRTy5xokWNzecgw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=328624306&repo=autoland&lineNumber=26053

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72259bba6056
implement KHR_blend_equation_advanced in SWGL. r=bradwerth

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/72259bba6056