Closed Bug 1674524 (sw-wr-perf-mix-blend) Opened 1 year ago Closed 10 months ago

Implement GL_KHR_blend_equation_advanced in swgl

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file, 4 obsolete files)

This would give us good mixed-blend-mode support. WebRender already has code to use this extension.

Blocks: 1674522
Severity: -- → S3
Blocks: sw-wr-perf
Blocks: 1681778
Alias: sw-wr-perf-mix-blend
Blocks: 1687308
Assignee: nobody → bwerth
Attachment #9198772 - Attachment is obsolete: true
Attachment #9198789 - Attachment is obsolete: true

Taking myself off the bug -- this one is beyond my capabilities, for now.

Assignee: bwerth → nobody
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Attachment #9199140 - Attachment is obsolete: true
Attachment #9199141 - Attachment is obsolete: true

This patch has a few moving parts. We have to first tell WR that when it
detects the extension that it is actually allowed to use it. We have to make
the glsl-to-cxx translator eat the blend_supports_all_equations layout
qualifier. We have to enable generation of advanced-blend-equation variants
in the SWGL build setup. Then we report the actual extension inside SWGL.
Finally, we actually add all the necessary blend equation enums, hash them
down to a blend key, and implement all the blend modes therein.

Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f71aafc4e845
implement KHR_blend_equation_advanced in SWGL. r=bradwerth
Depends on: 1690396
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72259bba6056
implement KHR_blend_equation_advanced in SWGL. r=bradwerth
See Also: → 1690401
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Depends on: 1694982
Regressions: 1700520
You need to log in before you can comment on or make changes to this bug.