168634 - Type ahead find only in visible page

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect, P2)

Description

[Marius Kotsbak]

Often on large pages when I scroll down, and then use the find ahead feature, I
get a hit on another place in the page, outside my view. Most of the time, I see
the link, and then don't want it to match somewhere else.

This happens when there are many links with the same name, like "see more" etc.

Therefore I think this should be an option, or/and something more intelligent,
as search the whole page if not finding anything in the visible part of the page.

Comment 1

[Aaron Leventhal]

It currently has 2 behaviors:
1. If an element on the page is focused or selected it will just search forward
from there.
2. If not (the page is focused), it prefers to find something visible on the
page. If it can't, then it will look below the viewport, and then finally wrap
around.

I've had people tell me this is good behavior, and what they want. Could you
specify more clearly for me what you'd like to see instead? You want it to only
find visible matches?

Comment 2

[Marius Kotsbak]

Could you explain what you in 1. mean by element?

I don't see 2. Steps to reproduce:

-Go to www.amazon.com
-scroll down below the first "read more"
-type "read more"
-the focus changes to the first "read more"-link (even after I have clicked on a
blank space somewhere under the first occurece).
(it might be because the search field is selected by default when I enter. If
this is the explanations, maybe 1. should distinguish between scripts changing
focus and me setting focus)

Comment 3

[Aaron Leventhal]

Ahh, I know why - it's because the page is 2 columns. You're right, it's not
working the way it should. I'll take a look at it. Thanks.

Comment 4

[Aaron Leventhal]

Attachment: Fixes problem by remembering "isFirstVisiblePreferred" as member variable, so that it doesn't get reset to false after 1st char is typed

Comment 5

[Kyle Yuan]

Comment on attachment 100664 [details] [diff] [review]
Fixes problem by remembering "isFirstVisiblePreferred" as member variable, so that it doesn't get reset to false after 1st char is typed

r=kyle

Comment 6

[Boris Zbarsky [:bzbarsky]]

sr=bzbarsky

Comment 7

[Aaron Leventhal]

checked in

Comment 8

[sairuh (rarely reading bugmail)]

vrfy'd fixed, 2002.09.26.08 mozilla trunk.