1686352 - Fix JS errors when interacting with Folder Mode Headers

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Alessandro Castellani [:aleca]]

A couple of minor errors when interacting with folder mode headers.

JavaScript error: chrome://messenger/content/folderPane.js, line 1327:
TypeError: can't access property "isServer", folder is null

JavaScript error: chrome://messenger/content/folderPane.js, line 2824:
TypeError: can't access property "invalidateRow", this._tree is null

Comment 1

[Alessandro Castellani [:aleca]]

Oh wow, this error: JavaScript error: chrome://messenger/content/folderPane.js, line 2824: TypeError: can't access property "invalidateRow", this._tree is null, was happening even before my patch.

Super obscure to reproduce.
Open the Account Settings > Synchronization & Storage and click on the "Advanced..." button to open the subdialog.
Close the subdialog by clicking on the X on the top right, not Cancel or OK, but just the X.
Go back on the Mail Tab and click "Get Messages".

It seems that the closing of the subdialog is not hooked to the gFolderTreeView.unload(); leaving that Tree still listening for property changes even if it doesn't exist aymore.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1686352-folder-pane-regressions.diff

This should fix the reported issues.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9196690 [details] [diff] [review]
1686352-folder-pane-regressions.diff

Review of attachment 9196690 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/content/msgSelectOfflineFolders.xhtml
@@ +12,5 @@
>          title="&MsgSelect.label;"
>          width="450" height="400"
>          persist="width height"
> +        onload="gSelectOffline.load();"
> +        onunload="gSelectOffline.unload();">

Please instead add something like
`
window.addEventListener("onunload", (event) => gFolderTreeView.unload(); });
`
... to msgSelectOfflineFolders.js 
You could move the onload handler there as well while you're at it

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1686352-folder-pane-regressions.diff

Perfect, thanks for the review.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e5a8c9dc16b
Fix Folder mode headers javascript errors. r=mkmelin