Closed Bug 1686480 Opened 11 months ago Closed 11 months ago

Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox86 fixed)

RESOLVED FIXED
86 Branch
Tracking Status
firefox86 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

In order to ease the landing of bug 1681698, I'm going to try landing this preliminary cleanup first.
Today, ThreadActor.attach and ThreadActor.reconfigure both receive the options dictionnary, made of many attribute to configure the thread actor. But these two methods accept different sets of attributes.
The goal here would be to ensure that all options currently passed to attach would also work if passed via reconfigure. So that bug 1681698 can do that for all the options that aren't being passed via the Watcher actor, and would still need to be passed on Target's attach sequence.

Blocks: 1686485
Blocks: 1686564

Bind onExceptionUnwind only once, remove unused _scripts attribute, create _debuggerSourcesSeen from constructor.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d3a4810639c
[devtools] A few naive cleanups in ThreadActor. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f9dceeaea9d8
[devtools] Allow all options currently passed to ThreadActor.attach to be passed via ThreadActor.reconfigure. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/76519f62b9c0
[devtools] Make ThreadActor.pauseOnExceptions just a wrapper to reconfigure method. r=nchevobbe
Severity: -- → S3
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.