Closed Bug 1686523 Opened 9 months ago Closed 8 months ago

Hide the home button by default

Categories

(Firefox :: Toolbars and Customization, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
87 Branch
Tracking Status
firefox87 --- fixed
firefox88 --- verified
firefox89 --- verified

People

(Reporter: mstriemer, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-toolbar])

Attachments

(1 file)

If the user's homepage is set to Firefox Home, and the home button hasn't been used recently, it should be removed from the toolbar. It should still be possible to manually add the home button back, and have it stay on the toolbar.

See Also: → 1686526
Whiteboard: [proton-toolbar]

The traditional way of doing this is:

  1. Removing the item from the default toolbar set here: https://searchfox.org/mozilla-central/rev/c03e8de87cdb0ce0378c0886d3c0ce8bbf9dc44e/browser/components/customizableui/CustomizableUI.jsm#244-254
  2. Add a migration to put the toolbar back for users that have used the button before in here: https://searchfox.org/mozilla-central/rev/c03e8de87cdb0ce0378c0886d3c0ce8bbf9dc44e/browser/components/customizableui/CustomizableUI.jsm#244-254
  3. In that same migration, remove the item for users that have customized their toolbars but never used the item

The problem here is timing. You can think of a UI migration almost like a database migration, except we're writing to the toolbar customization pref rather than a database. Yes, it's reversible, but the reversing requires additional logic, and it's all very state dependant.

I think the simplest thing to do is make the migration one-way, and if people test Proton, and then disable the pref, make sure they're aware that the things that were removed are in the customization palette. The less simple thing to do would be to somehow realize that Proton had been flipped on, and then flipped off, and put everything back. I suspect that this is more trouble than it's worth.

Assignee: nobody → emalysz
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cd494905b89
remove home button if proton is enabled and the button hasn't been used r=mstriemer,mconley
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Regressions: 1692351
Blocks: 1694817

Verified that the Home button is hidden by default. Tests were performed on Firefox 88.0b3 and Nightly 89.0a1 (2021-03-25) under Windows 10, macOS 10.15.7 and Ubuntu 20.04

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.