Closed Bug 1692351 Opened 3 years ago Closed 3 years ago

Can't start new profile with browser.proton.toolbar.enabled on

Categories

(Firefox :: Toolbars and Customization, defect, P1)

defect

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- unaffected
firefox87 --- fixed

People

(Reporter: mstriemer, Assigned: emmamalysz)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [proton-toolbar])

Attachments

(1 file)

The home button migration checks gSavedState.placements, but if the toolbar migration code is run on the first profile startup then gSavedState is null.

STR:

I did an artifact build:

  1. rm -rf obj-xyz/tmp/profile-default
  2. ./mach run --setpref browser.proton.toolbar.enabled=true

Expected results:
Functional Firefox without a home button

Actual results:
Nothing works (not even the close button on Windows, surprisingly).
This error: JavaScript error: resource:///modules/CustomizableUI.jsm, line 615: TypeError: can't access property "placements", gSavedState is null

Likely just needs a null check in the migration code. Looks like the other migration code [1] just flags itself as being migrated in this case, which makes sense to me.

[1] https://searchfox.org/mozilla-central/rev/d3343662ce0aced933b30e053b33c93f759292eb/browser/components/customizableui/CustomizableUI.jsm#355-364

Set release status flags based on info from the regressing bug 1686523

Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ca4c3365fae
add null check for gSavedState in proton toolbar migration r=mstriemer
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03df15114af7
add null check for gSavedState in proton toolbar migration r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Flags: needinfo?(emalysz)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: