Can't start new profile with browser.proton.toolbar.enabled on
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox85 | --- | unaffected |
firefox86 | --- | unaffected |
firefox87 | --- | fixed |
People
(Reporter: mstriemer, Assigned: emmamalysz)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [proton-toolbar])
Attachments
(1 file)
The home button migration checks gSavedState.placements
, but if the toolbar migration code is run on the first profile startup then gSavedState
is null.
STR:
I did an artifact build:
rm -rf obj-xyz/tmp/profile-default
./mach run --setpref browser.proton.toolbar.enabled=true
Expected results:
Functional Firefox without a home button
Actual results:
Nothing works (not even the close button on Windows, surprisingly).
This error: JavaScript error: resource:///modules/CustomizableUI.jsm, line 615: TypeError: can't access property "placements", gSavedState is null
Likely just needs a null check in the migration code. Looks like the other migration code [1] just flags itself as being migrated in this case, which makes sense to me.
Comment 1•3 years ago
|
||
Set release status flags based on info from the regressing bug 1686523
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
Updated•3 years ago
|
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ca4c3365fae add null check for gSavedState in proton toolbar migration r=mstriemer
Comment 4•3 years ago
|
||
Backed out changeset 1ca4c3365fae (bug 1692351) for bc failures in browser_970511_undo_restore_default.js.
https://hg.mozilla.org/integration/autoland/rev/90df77c721dd9353439673063e2c96e885119153
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=1ca4c3365fae2e475e45152995c27766847edea9&selectedTaskRun=CqopmT2vROCz5J05WV1HpQ.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=330308205&repo=autoland&lineNumber=8357
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03df15114af7 add null check for gSavedState in proton toolbar migration r=mstriemer
Updated•3 years ago
|
Comment 6•3 years ago
|
||
bugherder |
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Description
•