1686562 - Wrong text color for Mode Headers when using a Light theme with dark toolbar

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca]]

Attachment: Screenshot from 2021-01-13 12-33-36.png

It seems that the text color of the Folder Mode Headers is not properly following LWT variations with dark toolbars.
Tested using the Dark Blue theme.

Richard, could you work your magic on this?

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1686562-modeHeader-color.patch

Using var(--toolbar-color) wasn't so good as it uses then the colour also from LW-themes that don't style the trees.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9196928 [details] [diff] [review]
1686562-modeHeader-color.patch

Review of attachment 9196928 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this fixes it.
With a little nit.

::: mail/themes/shared/mail/folderPane.css
@@ +74,5 @@
>    border-top-style: none !important;
>  }
>  
>  treechildren::-moz-tree-cell-text(modeHeader) {
>    font-weight: bold;

Now that we're using the same color of the tree, we should decrease the boldness to 600 otherwise the text will look a bit too prominent.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1686562-modeHeader-color.patch

Updated wit r+ through Matrix.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0d25260b37eb
Don't use a variable for the modeHeader. r=aleca